From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56354)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VCxYD-0008LI-Ua
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 16:01:46 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VCxY8-0000QQ-Pm
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 16:01:41 -0400
Received: from mail-gh0-x22d.google.com ([2607:f8b0:4002:c05::22d]:50611)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VCxY8-0000QK-K0
	for qemu-devel@nongnu.org; Fri, 23 Aug 2013 16:01:36 -0400
Received: by mail-gh0-f173.google.com with SMTP id g16so264505ghb.32
	for <qemu-devel@nongnu.org>; Fri, 23 Aug 2013 13:01:36 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <5217BF9B.9040503@twiddle.net>
Date: Fri, 23 Aug 2013 13:01:31 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <5217B34F.4090508@markus-regensburg.de>
In-Reply-To: <5217B34F.4090508@markus-regensburg.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [qemu-devel] [PATCH v2] target-i386: Fix segment
 cache dump
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tobias Markus <tobias@markus-regensburg.de>
Cc: qemu-devel@nongnu.org

On 08/23/2013 12:09 PM, Tobias Markus wrote:
> When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default operation size bit (D/B bit) is not set for Long Mode Data Segments since there are only Data Segments in Long Mode and no explicit 16/32/64-bit Descriptors.
> This patch fixes this by checking the Long Mode Active bit of the hidden flags variable and logging "DS" if it is set. (I.e. in Long Mode all Data Segments are logged as "DS")
> 
> Signed-off-by: Tobias Markus <tobias@markus-regensburg.de>

Reviewed-by: Richard Henderson <rth@twiddle.net>

> +            cpu_fprintf(f, (sc->flags & DESC_B_MASK ||
> +                        env->hflags & HF_LMA_MASK)
> +                        ? "DS  " : "DS16");

Though we don't have anything in CODING_STYLE that mandates this,
IMO expressions shouldn't "unindent" in the middle like this.

Better as

           cpu_fprintf(f, (sc->flags & DESC_B_MASK
                           || env->hflags & HF_LMA_MASK
                           ? "DS  " : "DS16"));

but that's just me and emacs...


r~