From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCzE5-0003e3-Uh for qemu-devel@nongnu.org; Fri, 23 Aug 2013 17:49:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VCzE1-0002xB-1W for qemu-devel@nongnu.org; Fri, 23 Aug 2013 17:49:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VCzE0-0002x4-NK for qemu-devel@nongnu.org; Fri, 23 Aug 2013 17:48:56 -0400 Message-ID: <5217D8C5.8000408@redhat.com> Date: Fri, 23 Aug 2013 15:48:53 -0600 From: Eric Blake MIME-Version: 1.0 References: <5217B34F.4090508@markus-regensburg.de> <5217BF9B.9040503@twiddle.net> <5217D699.7090502@markus-regensburg.de> In-Reply-To: <5217D699.7090502@markus-regensburg.de> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="dPffnef9PfPHGEEF4EajQ3x5PFq7gsT00" Subject: Re: [Qemu-devel] [PATCH v2] target-i386: Fix segment cache dump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tobias Markus Cc: qemu-devel@nongnu.org, Richard Henderson This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --dPffnef9PfPHGEEF4EajQ3x5PFq7gsT00 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/23/2013 03:39 PM, Tobias Markus wrote: > Alternatively, for readability: > + cpu_fprintf(f, (sc->flags & DESC_B_MASK || env->hflags & H= F_LMA_MASK) > + ? "DS " : "DS16"); > The upper line would be 82 characters long. I'm not sure how strictly l= ine width is enforced. > (Other lines in that file (target-i386/helper.c) also exceed the width = limit.) This instance can get below 80 with one more line wrap: + cpu_fprintf(f, + (sc->flags & DESC_B_MASK || env->hflags & HF_LMA_MASK) + ? "DS " : "DS16"); --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --dPffnef9PfPHGEEF4EajQ3x5PFq7gsT00 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSF9jFAAoJEKeha0olJ0NqNnIH/2kP5OGuuwu8AESAsr1kETPI HHXwgpSu9k4LjC8IUhsDIqo4scm05rtXU0LU1o0HXI5kSe5c/UR3vNUfi3xUtmwO GTlTpNRd75CVwM8q2QNUL15gFhpe7N2Jvv9AHCRoXDA/NY4GVotnv2Ms6M5U7zMV AuPrBl7XUmN2T47ACT1r6oHVYdm1RRAAahKnBUiahlENBSZ3cfeU7MUyZcUfg0BZ A1GMQBIgzOY/l9DK+o4sIvcR1wSjcc7zF/I8gEEg/gro78S2ALyZXDY11bb7/P5h LLJppYT52LjYeoh6GiIdeHuJDoD+OMa2l2T3jPEF/ua6OPqEsoImBJ+19YcDC6U= =Z//k -----END PGP SIGNATURE----- --dPffnef9PfPHGEEF4EajQ3x5PFq7gsT00--