From: Kang Kai <Kai.Kang@windriver.com>
To: Kang Kai <Kai.Kang@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] bc: fix segmentation fault
Date: Mon, 26 Aug 2013 10:54:06 +0800 [thread overview]
Message-ID: <521AC34E.3060701@windriver.com> (raw)
In-Reply-To: <5215BCD0.7080902@windriver.com>
On 2013年08月22日 15:25, Kang Kai wrote:
> On 2013年08月22日 15:15, Khem Raj wrote:
>> Kai
>>
>> On Aug 21, 2013, at 11:50 PM, Kang Kai <Kai.Kang@windriver.com> wrote:
>>
>>>> what does adding this include file fix ?
>>> To be honest, I am not sure why add this include. After build it is
>>> harmless, so I didn't want to modify it because I think LFS is
>>> trustable.
>>>
Hi Raj,
>> Its matter of understanding the change and may be explaining a bit
>> better what it fixes and make the patch better for upstream too so
>> try to build it without this include added and see if you get some
>> warnings/errors that it fixes and then add that information to patch
>> header.
It is no warning shows without the include patch. But the patch is merged.
Sorry again.
Kai
>
> Thanks.
> I'll check it and be more careful next time.
>
> Regards,
> Kai
>
>>
>>> Regards,
>>> Kai
>>
>>
>
>
--
Regards,
Neil | Kai Kang
prev parent reply other threads:[~2013-08-26 2:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-20 2:20 [PATCH 0/1] Fix bc segmentation fault Kai Kang
2013-08-20 2:20 ` [PATCH 1/1] bc: fix " Kai Kang
2013-08-22 6:38 ` Khem Raj
2013-08-22 6:50 ` Kang Kai
2013-08-22 7:15 ` Khem Raj
2013-08-22 7:25 ` Kang Kai
2013-08-26 2:54 ` Kang Kai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521AC34E.3060701@windriver.com \
--to=kai.kang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.