From: Sujit Reddy Thumma <sthumma@codeaurora.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Santosh Y <santoshsy@gmail.com>,
linux-scsi@vger.kernel.org, vinholikatti@gmail.com,
Dolev Raviv <draviv@codeaurora.org>
Subject: Re: [PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU
Date: Mon, 26 Aug 2013 08:41:32 +0530 [thread overview]
Message-ID: <521AC764.5030001@codeaurora.org> (raw)
In-Reply-To: <1377281830.4147.61.camel@dabdike>
On 8/23/2013 11:47 PM, James Bottomley wrote:
>
> On Tue, 2013-07-30 at 00:35 +0530, Santosh Y wrote:
>> From: Sujit Reddy Thumma <sthumma@codeaurora.org>
>>
>> As part of device initialization sequence, sending NOP OUT UPIU and
>> waiting for NOP IN UPIU response is mandatory. This confirms that the
>> device UFS Transport (UTP) layer is functional and the host can configure
>> the device with further commands. Add support for sending NOP OUT UPIU to
>> check the device connection path and test whether the UTP layer on the
>> device side is functional during initialization.
>>
>> A tag is acquired from the SCSI tag map space in order to send the device
>> management command. When the tag is acquired by internal command the scsi
>> command is rejected with host busy flag in order to requeue the request.
>> To avoid frequent collisions between internal commands and scsi commands
>> the device management command tag is allocated in the opposite direction
>> w.r.t block layer tag allocation.
>>
>> Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>
>> Signed-off-by: Dolev Raviv <draviv@codeaurora.org>
>> Signed-off-by: Santosh Y <santoshsy@gmail.com>
>
> This signoff chain looks wrong to me. The patch has quite a long
> history. Originally, it was sent in by Sujit, then later resent by
> Dolev with his signoff, then Sujit did a V2 which incorrectly seemed to
> include Dolev's signoff (that's not correct: signoffs should follow the
> chain of transmission, so a new patch wouldn't have a previous
> transmission signoff).
Initially we had two patches -
scsi: ufs: add support for query requests authored by Dolev and
scsi: ufs: Add support for sending NOP OUT UPIU authored by me.
Based on a possible design issue with the former patch, Dolev merged
the patch into the later (NOP OUT patch).
http://thread.gmane.org/gmane.linux.ports.arm.msm/4202/focus=1505731
Since some of the contents are picked from the original patch during
rework, I have asked Dolev include his Signed-off-by as a co-author.
Then we got a V3 which was tested by Maya Erez,
> and finally a v4 which looks to have no testers. In your last
> submission, you picked up this signoff, so I've changed it to a
> reviewed-by which seems to be the most appropriate (although I'm not
> entirely sure Dolev did review the v4 patch).
>
> If this is wrong and Dolev did rewrite the patch (so is one of the
> authors, which would explain the signoff chain) let me know and I'll
> edit it in the tree (rebasing is acceptable to get the correct history).
>
> James
>
>
>
--
Regards,
Sujit
next prev parent reply other threads:[~2013-08-26 3:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 19:05 [PATCH 0/9] scsi:ufs: query, bkops support and other fixes Santosh Y
2013-07-29 19:05 ` [PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU Santosh Y
2013-08-23 18:17 ` James Bottomley
2013-08-26 3:11 ` Sujit Reddy Thumma [this message]
2013-08-26 8:55 ` James Bottomley
2013-07-29 19:05 ` [PATCH 2/9] scsi: ufs: Set fDeviceInit flag to initiate device initialization Santosh Y
2013-07-29 19:05 ` [PATCH 3/9] scsi: ufs: Add support for host assisted background operations Santosh Y
2013-07-29 19:06 ` [PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver Santosh Y
2013-07-29 19:06 ` [PATCH 5/9] ufshcd-pci: release ioremapped region during removing driver Santosh Y
2013-07-29 19:06 ` [PATCH 6/9] ufs: don't disable_irq() if the IRQ can be shared among devices Santosh Y
2013-07-29 19:06 ` [PATCH 7/9] ufs: don't stop controller before scsi_remove_host() Santosh Y
2013-07-29 19:06 ` [PATCH 8/9] ufshcd-pltfrm: remove redundant dev_err call in ufshcd_pltfrm_probe() Santosh Y
2013-07-29 19:06 ` [PATCH 9/9] drivers/scsi/ufs: don't check resource with devm_ioremap_resource Santosh Y
-- strict thread matches above, loose matches on Subject: below --
2013-07-28 17:10 [PATCH 0/9] scsi:ufs: query, bkops support and other fixes Santosh Y
2013-07-28 17:10 ` [PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU Santosh Y
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521AC764.5030001@codeaurora.org \
--to=sthumma@codeaurora.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=draviv@codeaurora.org \
--cc=linux-scsi@vger.kernel.org \
--cc=santoshsy@gmail.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.