From mboxrd@z Thu Jan 1 00:00:00 1970 From: b.brezillon@overkiz.com (boris brezillon) Date: Mon, 26 Aug 2013 15:33:59 +0200 Subject: [PATCH v2 2/2] ARM: at91/dt: define phy available on sama5d3 mother board In-Reply-To: <521B5648.3020608@cogentembedded.com> References: <1377520431-21807-1-git-send-email-b.brezillon@overkiz.com> <1377520540-21884-1-git-send-email-b.brezillon@overkiz.com> <521B5648.3020608@cogentembedded.com> Message-ID: <521B5947.6050009@overkiz.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Sergei, On 26/08/2013 15:21, Sergei Shtylyov wrote: > Hello. > > On 26-08-2013 16:35, Boris BREZILLON wrote: > >> This patch describe the phy used on atmel sama5d3 mother board: >> - phy address >> - phy interrupt pin > >> Signed-off-by: Boris BREZILLON >> --- >> arch/arm/boot/dts/sama5d3xmb.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) > >> diff --git a/arch/arm/boot/dts/sama5d3xmb.dtsi >> b/arch/arm/boot/dts/sama5d3xmb.dtsi >> index 8a9e05d..e9521d5 100644 >> --- a/arch/arm/boot/dts/sama5d3xmb.dtsi >> +++ b/arch/arm/boot/dts/sama5d3xmb.dtsi >> @@ -81,6 +81,14 @@ >> >> macb1: ethernet at f802c000 { >> phy-mode = "rmii"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + phy0: ethernet-phy at 0 { > > Address part of the node name doesn't match the "reg" property. Indeed, I based my definition on arch/arc/boot/dts/angel4.dts where phy is registered like this : phy0: ethernet-phy at 0 { reg = <1>; }; I think it's buggy there too, because I checked other dts files and they all put the same address after @ and in reg register. I'll fix this fot the next version. Thanks Best Regards, Boris > >> + interrupt-parent = <&pioE>; >> + interrupts = <30 IRQ_TYPE_EDGE_FALLING>; >> + reg = <1>; >> + }; > > WBR, Sergei > From mboxrd@z Thu Jan 1 00:00:00 1970 From: boris brezillon Subject: Re: [PATCH v2 2/2] ARM: at91/dt: define phy available on sama5d3 mother board Date: Mon, 26 Aug 2013 15:33:59 +0200 Message-ID: <521B5947.6050009@overkiz.com> References: <1377520431-21807-1-git-send-email-b.brezillon@overkiz.com> <1377520540-21884-1-git-send-email-b.brezillon@overkiz.com> <521B5648.3020608@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <521B5648.3020608@cogentembedded.com> Sender: netdev-owner@vger.kernel.org To: Sergei Shtylyov Cc: Rob Herring , Pawel Moll , Mark Rutland , Stephen Warren , Ian Campbell , Russell King , Nicolas Ferre , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org List-Id: devicetree@vger.kernel.org Hello Sergei, On 26/08/2013 15:21, Sergei Shtylyov wrote: > Hello. > > On 26-08-2013 16:35, Boris BREZILLON wrote: > >> This patch describe the phy used on atmel sama5d3 mother board: >> - phy address >> - phy interrupt pin > >> Signed-off-by: Boris BREZILLON >> --- >> arch/arm/boot/dts/sama5d3xmb.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) > >> diff --git a/arch/arm/boot/dts/sama5d3xmb.dtsi >> b/arch/arm/boot/dts/sama5d3xmb.dtsi >> index 8a9e05d..e9521d5 100644 >> --- a/arch/arm/boot/dts/sama5d3xmb.dtsi >> +++ b/arch/arm/boot/dts/sama5d3xmb.dtsi >> @@ -81,6 +81,14 @@ >> >> macb1: ethernet@f802c000 { >> phy-mode = "rmii"; >> + >> + #address-cells = <1>; >> + #size-cells = <0>; >> + phy0: ethernet-phy@0 { > > Address part of the node name doesn't match the "reg" property. Indeed, I based my definition on arch/arc/boot/dts/angel4.dts where phy is registered like this : phy0: ethernet-phy@0 { reg = <1>; }; I think it's buggy there too, because I checked other dts files and they all put the same address after @ and in reg register. I'll fix this fot the next version. Thanks Best Regards, Boris > >> + interrupt-parent = <&pioE>; >> + interrupts = <30 IRQ_TYPE_EDGE_FALLING>; >> + reg = <1>; >> + }; > > WBR, Sergei >