From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55545)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VDxsM-00026y-KZ
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 10:34:44 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VDxsG-0000Z0-G6
	for qemu-devel@nongnu.org; Mon, 26 Aug 2013 10:34:38 -0400
Message-ID: <521B6775.5060102@suse.de>
Date: Mon, 26 Aug 2013 16:34:29 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1376344938-21374-1-git-send-email-pbonzini@redhat.com>
	<521B483D.9090203@redhat.com>
In-Reply-To: <521B483D.9090203@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org

Am 26.08.2013 14:21, schrieb Paolo Bonzini:
> Il 13/08/2013 00:02, Paolo Bonzini ha scritto:
>> vapic requires the VAPIC ROM to be mapped into RAM.  This is not
>> possible without PAM hardware.  This fixes a segmentation fault
>> running with -M isapc.
>>
>> Cc: qemu-stable@nongnu.org
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> ---
>>
>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
>> index a19e172..3aa244a 100644
>> --- a/hw/i386/pc_piix.c
>> +++ b/hw/i386/pc_piix.c
>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine =3D {
>>      .init =3D pc_init_isa,
>>      .max_cpus =3D 1,
>>      .compat_props =3D (GlobalProperty[]) {
>> +        {
>> +            .driver   =3D "apic-common",
>> +            .property =3D "kvmvapic",
>> +            .value    =3D "off",
>> +        },
>>          { /* end of list */ }
>>      },
>>      DEFAULT_MACHINE_OPTIONS,
>>
>=20
> Ping.

I had double-checked that my pending qom-test covers isapc and succeeds
with and without your patch, so apparently this is visible at runtime onl=
y.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg