From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDyIY-0006bo-4Y for qemu-devel@nongnu.org; Mon, 26 Aug 2013 11:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDyIS-00027y-F1 for qemu-devel@nongnu.org; Mon, 26 Aug 2013 11:01:42 -0400 Message-ID: <521B6DCB.9030505@redhat.com> Date: Mon, 26 Aug 2013 17:01:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1376344938-21374-1-git-send-email-pbonzini@redhat.com> <521B483D.9090203@redhat.com> <521B6775.5060102@suse.de> In-Reply-To: <521B6775.5060102@suse.de> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-1?Q?Andreas_F=E4rber?= Cc: qemu-devel@nongnu.org, qemu-stable@nongnu.org Il 26/08/2013 16:34, Andreas F=E4rber ha scritto: > Am 26.08.2013 14:21, schrieb Paolo Bonzini: >> Il 13/08/2013 00:02, Paolo Bonzini ha scritto: >>> vapic requires the VAPIC ROM to be mapped into RAM. This is not >>> possible without PAM hardware. This fixes a segmentation fault >>> running with -M isapc. >>> >>> Cc: qemu-stable@nongnu.org >>> Signed-off-by: Paolo Bonzini >>> --- >>> >>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>> index a19e172..3aa244a 100644 >>> --- a/hw/i386/pc_piix.c >>> +++ b/hw/i386/pc_piix.c >>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine =3D { >>> .init =3D pc_init_isa, >>> .max_cpus =3D 1, >>> .compat_props =3D (GlobalProperty[]) { >>> + { >>> + .driver =3D "apic-common", >>> + .property =3D "kvmvapic", >>> + .value =3D "off", >>> + }, >>> { /* end of list */ } >>> }, >>> DEFAULT_MACHINE_OPTIONS, >>> >> >> Ping. >=20 > I had double-checked that my pending qom-test covers isapc and succeeds > with and without your patch, so apparently this is visible at runtime o= nly. Yes, it only happens after kvmvapic is actually enabled by the option ROM. Paolo