From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VDyXe-0002nE-2D for qemu-devel@nongnu.org; Mon, 26 Aug 2013 11:17:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VDyXX-0007UG-6j for qemu-devel@nongnu.org; Mon, 26 Aug 2013 11:17:17 -0400 Message-ID: <521B7173.1030505@suse.de> Date: Mon, 26 Aug 2013 17:17:07 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1376344938-21374-1-git-send-email-pbonzini@redhat.com> <521B483D.9090203@redhat.com> <521B6775.5060102@suse.de> <521B6DCB.9030505@redhat.com> In-Reply-To: <521B6DCB.9030505@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-1.6] isapc: disable kvmvapic List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, qemu-stable@nongnu.org Am 26.08.2013 17:01, schrieb Paolo Bonzini: > Il 26/08/2013 16:34, Andreas F=E4rber ha scritto: >> Am 26.08.2013 14:21, schrieb Paolo Bonzini: >>> Il 13/08/2013 00:02, Paolo Bonzini ha scritto: >>>> vapic requires the VAPIC ROM to be mapped into RAM. This is not >>>> possible without PAM hardware. This fixes a segmentation fault >>>> running with -M isapc. >>>> >>>> Cc: qemu-stable@nongnu.org >>>> Signed-off-by: Paolo Bonzini >>>> --- >>>> >>>> diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c >>>> index a19e172..3aa244a 100644 >>>> --- a/hw/i386/pc_piix.c >>>> +++ b/hw/i386/pc_piix.c >>>> @@ -743,6 +743,11 @@ static QEMUMachine isapc_machine =3D { >>>> .init =3D pc_init_isa, >>>> .max_cpus =3D 1, >>>> .compat_props =3D (GlobalProperty[]) { >>>> + { >>>> + .driver =3D "apic-common", >>>> + .property =3D "kvmvapic", >>>> + .value =3D "off", >>>> + }, >>>> { /* end of list */ } >>>> }, >>>> DEFAULT_MACHINE_OPTIONS, >>>> >>> >>> Ping. >> >> I had double-checked that my pending qom-test covers isapc and succeed= s >> with and without your patch, so apparently this is visible at runtime = only. >=20 > Yes, it only happens after kvmvapic is actually enabled by the option R= OM. Maybe Michael can pick it up along with the compat refactorings? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg