From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v9 2/2] console: usb: kbd: To improve TFTP booting performance
Date: Mon, 26 Aug 2013 10:05:11 -0600 [thread overview]
Message-ID: <521B7CB7.6020402@wwwdotorg.org> (raw)
In-Reply-To: <201308261331.59684.marex@denx.de>
On 08/26/2013 05:31 AM, Marek Vasut wrote:
> Dear Jim Lin,
>
>> Marek,
>> In common/usb_kbd.c, you applied code to wrong place.
>> You should apply my change to function usb_kbd_testc(), instead of
>> usb_kbd_getc(). Could you help to correct it?
>>
>
> I believe I applied your patches. Anyway, submit a subsequent patch against u-
> boot-usb/master please.
Marek, did you apply the patch using "git am", "patch", or by
hand-editing? Looking at the fixup patch that Jim sent, the patch
context is identical in both places, so perhaps this exposed some issue
with git/... - it'd be useful to understand how the problem occurred, so
it can be fixed.
next prev parent reply other threads:[~2013-08-26 16:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-13 11:04 [U-Boot] [PATCH v9 2/2] console: usb: kbd: To improve TFTP booting performance Jim Lin
2013-08-21 4:27 ` Marek Vasut
2013-08-26 11:19 ` Jim Lin
2013-08-26 11:31 ` Marek Vasut
2013-08-26 16:05 ` Stephen Warren [this message]
2013-08-26 16:28 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521B7CB7.6020402@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.