From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 4/4] SVM: streamline entry.S code
Date: Mon, 26 Aug 2013 18:46:40 +0100
Message-ID: <521B9480.6080509@citrix.com>
References: <CE414CE4.5B85E%keir.xen@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta4.messagelabs.com ([85.158.143.247])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <Andrew.Cooper3@citrix.com>) id 1VE0sG-0004kN-9o
	for xen-devel@lists.xenproject.org; Mon, 26 Aug 2013 17:46:44 +0000
In-Reply-To: <CE414CE4.5B85E%keir.xen@gmail.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Keir Fraser <keir.xen@gmail.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Boris Ostrovsky <boris.ostrovsky@oracle.com>, Jacob Shin <jacob.shin@amd.com>, suravee.suthikulpanit@amd.com, Jan Beulich <JBeulich@suse.com>
List-Id: xen-devel@lists.xenproject.org

On 26/08/2013 18:20, Keir Fraser wrote:
>
>>  However, I cant find anywhere in the code which overwrites regs->rax from
>> vmcb->rax, which I would have thought would have thought would cause utter
>> devastation in combination with the generic functions working with a
>> cpu_user_regs structure.
> It's right there in entry.S: 'mov VMCB_rax(%rcx),%rax; mov
> %rax,UREGS_rax(%rsp)'

So it is.  I feel quite silly right about now.  I suspect that I have
been staring at this code a bit too long.

~Andrew