All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mikhail Durnev <Mikhail_Durnev@mentor.com>
To: <paul.eggleton@linux.intel.com>
Cc: openembedded-core <openembedded-core@lists.openembedded.org>
Subject: classes/insane: add check for PN in OVERRIDES
Date: Tue, 27 Aug 2013 17:36:03 +1100	[thread overview]
Message-ID: <521C48D3.3010901@mentor.com> (raw)

Hello Paul,

I have a question about your commit c331f0a:

-------------------------------------------
diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 4d2392e..fb18022 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -907,6 +907,11 @@ python () {
      if d.getVar('do_stage', True) is not None:
          bb.fatal("Legacy staging found for %s as it has a do_stage 
function. This will need conversion to a do_install or often simply 
removal to work with OE-core" % d.getVar("FILE", True))

+    overrides = d.getVar('OVERRIDES', True).split(':')
+    pn = d.getVar('PN', True)
+    if pn in overrides:
+        bb.warn('Recipe %s has PN of "%s" which is in OVERRIDES, this 
can result in unexpected behaviour.' % (d.getVar("FILE", True), pn))
+
      issues = []
      if (d.getVar('PACKAGES', True) or "").split():
          for var in 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 
'RCONFLICTS', 'RPROVIDES', 'RREPLACES', 'FILES', 'pkg_preinst', 
'pkg_postinst', 'pkg_prerm', 'pkg_postrm', 'ALLOW_EMPTY':
----------------------------------------------

A recipe (lets say linux_git.bb) has its PN in OVERRIDES with prefix 
'pn-' (pn-linux). So, if we have 'linux' in OVERRIDES then it cannot 
interfere. Should we search for pn-${PN} instead? E.g.:

     overrides = d.getVar('OVERRIDES', True).split(':')
     pn = d.getVar('PN', True)
     if ("pn-%s" % pn) in overrides:
         bb.warn('Recipe %s has PN of "%s" which is in OVERRIDES, this 
can result in unexpected behaviour.' % (d.getVar("FILE", True), pn))

Thanks,
Mikhail


             reply	other threads:[~2013-08-27  6:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  6:36 Mikhail Durnev [this message]
2013-08-28  8:41 ` classes/insane: add check for PN in OVERRIDES Paul Eggleton
2013-08-28 10:54   ` Mikhail Durnev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521C48D3.3010901@mentor.com \
    --to=mikhail_durnev@mentor.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.