From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: Request fairly urgent reversion of c/s 8a3c4acc9907cfec9aae9f1bc251fbf50af6828e Date: Tue, 27 Aug 2013 15:06:18 +0100 Message-ID: <521CB25A.3000305@citrix.com> References: <521CA36A.4060204@citrix.com> <521CC2DA02000078000EEC1C@nat28.tlf.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1VEJun-00068j-UP for xen-devel@lists.xenproject.org; Tue, 27 Aug 2013 14:06:38 +0000 In-Reply-To: <521CC2DA02000078000EEC1C@nat28.tlf.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich Cc: xen-devel , Keir Fraser List-Id: xen-devel@lists.xenproject.org On 27/08/13 14:16, Jan Beulich wrote: >>>> On 27.08.13 at 15:02, Andrew Cooper wrote: >> Changeset 8a3c4acc9907cfec9aae9f1bc251fbf50af6828e is my "Clean stacks >> in debug builds patch" >> >> I applied the upstream version to XenServer, and resulted in some >> spectacular fails to boot. >> >> Curiously, the buggy V1 "$(STACK_SIZE >> 8) " works fine on all >> hardware, but the apparently correct "$(STACK_SIZE / 8)" causes complete >> deadlock on AMD boxes on AP bringup, and causes Intel boxes to only boot >> a single pcpu. > That original version was broken in the assembly version only iirc, > which should not get used in AP bring-up. Hence I'm puzzled. Me too. Literally changing the "$(STACK_SIZE / 8)" to "$(STACK_SIZE >> 8)" is sufficient to prevent the problem. I am investigating now. ~Andrew