From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH RFC 2/2] AMD IOMMU: allow command line
 overrides for broken IVRS tables
Date: Tue, 27 Aug 2013 15:15:04 +0100
Message-ID: <521CB468.3020408@citrix.com>
References: <1831656044.20130722225004@eikelenboom.it>
	<51FF74E502000078000E9267@nat28.tlf.novell.com>
	<52011A78.2040701@amd.com>
	<757500547.20130815164341@eikelenboom.it>
	<520D0CBF02000078000EC4FF@nat28.tlf.novell.com>
	<1182640844.20130816012228@eikelenboom.it>
	<33876223.20130816014116@eikelenboom.it>
	<520DEEFD02000078000EC76F@nat28.tlf.novell.com>
	<208201973.20130816094246@eikelenboom.it>
	<520DF8F302000078000EC7AD@nat28.tlf.novell.com>
	<1157392160.20130816104005@eikelenboom.it>
	<520E0AA002000078000EC82B@nat28.tlf.novell.com>
	<451541998.20130816124429@eikelenboom.it>
	<520E422602000078000EC94D@nat28.tlf.novell.com>
	<1834274604.20130823005128@eikelenboom.it>
	<521C78A602000078000EEA44@nat28.tlf.novell.com>
	<521C79F502000078000EEA56@nat28.tlf.novell.com>
	<759475415.20130827115236@eikelenboom.it>
	<835047997.20130827130902@eikelenboom.it>
	<521CB1F602000078000EEBCD@nat28.tlf.novell.com>
	<203972048.20130827153218@eikelenboom.it>
	<521CCBE002000078000EECAF@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <521CCBE002000078000EECAF@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: Keir Fraser <keir@xen.org>, Suravee Suthikulanit <suravee.suthikulpanit@amd.com>, Jan Beulich <JBeulich@suse.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 27/08/13 14:55, Jan Beulich wrote:
>>>> On 27.08.13 at 15:32, Sander Eikelenboom <linux@eikelenboom.it> wrote:
>> Hmmm even with:
>>
>> static void __init parse_ivrs_ioapic(char *str)
>> {
>>     const char *s = str;
>>     unsigned long id;
>>     unsigned int seg, bus, dev, func;
>>
>>     AMD_IOMMU_DEBUG(" will be parsing things: %s" , str);
>>
>>     ASSERT(*s == '[');
>>     id = simple_strtoul(s + 1, &s, 0);
>>     if ( id >= ARRAY_SIZE(ioapic_sbdf) || *s != ']' || *++s != '=' ){
>>         AMD_IOMMU_DEBUG("bailing out here %lu" , id);
>>
>>         return;
>>     }
>>     s = parse_pci(s + 1, &seg, &bus, &dev, &func);
>>     if ( !s || *s ){
>>
>>             AMD_IOMMU_DEBUG(" Something went wrong parsing things: %s" , 
>> str);
>>             return;
>>     }
>>     AMD_IOMMU_DEBUG("parsed things: %lu, %d, %d , %d" ,id, bus, dev, func);
>>
>>     ioapic_sbdf[id].bdf = PCI_BDF(bus, dev, func);
>>     ioapic_sbdf[id].seg = seg;
>>     __set_bit(id, ioapic_cmdline);
>> }
>> custom_param("ivrs_ioapic[", parse_ivrs_ioapic);
>>
>> I don't see anything ...
> That's not surprising - command line parsing happens before any
> consoles get set up.
>
> Jan
>

If you have a serial console enabled, then you will see those prints,
but they will not show up in `xl dmesg`

~Andrew