diff for duplicates of <521CB662.3050903@cogentembedded.com> diff --git a/a/1.txt b/N1/1.txt index d194916..294266a 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -27,16 +27,16 @@ On 27-08-2013 18:06, Daniel Borkmann wrote: > int result; > > - /* Verify stream values are non-zero. */ -> - if ((0 = peer_init->init_hdr.num_outbound_streams) || -> - (0 = peer_init->init_hdr.num_inbound_streams) || -> - (0 = peer_init->init_hdr.init_tag) || +> - if ((0 == peer_init->init_hdr.num_outbound_streams) || +> - (0 == peer_init->init_hdr.num_inbound_streams) || +> - (0 == peer_init->init_hdr.init_tag) || > - (SCTP_DEFAULT_MINWINDOW > ntohl(peer_init->init_hdr.a_rwnd))) { > - > + /* Check for missing mandatory parameters. Note: Initial TSN is > + * also mandatory, but is not checked here since the valid range > + * is 0..2**(32-1). RFC4960, section 3.3.3. - I don't think you really meant 2**(32-1) = 2**31. Previously you wrote + I don't think you really meant 2**(32-1) == 2**31. Previously you wrote 2**32-1. WBR, Sergei diff --git a/a/content_digest b/N1/content_digest index 8265724..faf4a44 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,7 +1,7 @@ "ref\01377612363-10779-1-git-send-email-dborkman@redhat.com\0" "From\0Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>\0" "Subject\0Re: [PATCH net-next v2] net: sctp: sctp_verify_init: clean up mandatory checks and add comment\0" - "Date\0Tue, 27 Aug 2013 14:23:30 +0000\0" + "Date\0Tue, 27 Aug 2013 18:23:30 +0400\0" "To\0Daniel Borkmann <dborkman@redhat.com>\0" "Cc\0davem@davemloft.net" netdev@vger.kernel.org @@ -37,18 +37,18 @@ "> \tint result;\n" ">\n" "> -\t/* Verify stream values are non-zero. */\n" - "> -\tif ((0 = peer_init->init_hdr.num_outbound_streams) ||\n" - "> -\t (0 = peer_init->init_hdr.num_inbound_streams) ||\n" - "> -\t (0 = peer_init->init_hdr.init_tag) ||\n" + "> -\tif ((0 == peer_init->init_hdr.num_outbound_streams) ||\n" + "> -\t (0 == peer_init->init_hdr.num_inbound_streams) ||\n" + "> -\t (0 == peer_init->init_hdr.init_tag) ||\n" "> -\t (SCTP_DEFAULT_MINWINDOW > ntohl(peer_init->init_hdr.a_rwnd))) {\n" "> -\n" "> +\t/* Check for missing mandatory parameters. Note: Initial TSN is\n" "> +\t * also mandatory, but is not checked here since the valid range\n" "> +\t * is 0..2**(32-1). RFC4960, section 3.3.3.\n" "\n" - " I don't think you really meant 2**(32-1) = 2**31. Previously you wrote \n" + " I don't think you really meant 2**(32-1) == 2**31. Previously you wrote \n" "2**32-1.\n" "\n" WBR, Sergei -10ed3b118ef2a40fe88c4a6dc9e15b877bd6ab6a73718982c632716ce937d299 +f1669db6974df4b676f5b5bfedeeee21bd33ff1cb132cf55b92d7cdb530f9ea6
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.