All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
Subject: Re: [cbootimage PATCH V2] crypto: produce consistent hash for zero-length data
Date: Tue, 27 Aug 2013 10:05:28 -0600	[thread overview]
Message-ID: <521CCE48.5060701@wwwdotorg.org> (raw)
In-Reply-To: <20130827074835.GF8686@ulmo>

On 08/27/2013 01:48 AM, Thierry Reding wrote:
> On Mon, Aug 26, 2013 at 04:12:50PM -0600, Stephen Warren wrote:
>> From: Stephen Warren <swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
>> 
>> In real-world use-cases, hashing zero-length data likely never
>> happens. However, it is relevant when testing cbootimage with a
>> dummy zero-length bootloader binary, e.g.:
>> 
>> touch u-boot.bin cbootimage -t30 ../tamonten-ng/tegra30.img.cfg
>> tegra30-tec-ng.img
>> 
>> In this scenario, it's useful to create a consistent hash, so
>> that one can compare the resultant images before and after
>> applying patches, to check for regressions.
>> 
>> Hence, zero out the hash data so it has consistent content if it
>> isn't written to.
...
> Looks good:
> 
> Reviewed-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>

Thanks. I've pushed this out.

      reply	other threads:[~2013-08-27 16:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-26 22:12 [cbootimage PATCH V2] crypto: produce consistent hash for zero-length data Stephen Warren
     [not found] ` <1377555170-6841-1-git-send-email-swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-08-27  7:48   ` Thierry Reding
2013-08-27 16:05     ` Stephen Warren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521CCE48.5060701@wwwdotorg.org \
    --to=swarren-3lzwwm7+weoh9zmkesr00q@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.