From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gerlach Subject: Re: [PATCH 1/2] ARM: AM335x: Get rid of unused sram init function Date: Tue, 27 Aug 2013 11:06:35 -0500 Message-ID: <521CCE8B.4050907@ti.com> References: <1377598305-15539-1-git-send-email-rnayak@ti.com> <1377598305-15539-2-git-send-email-rnayak@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from bear.ext.ti.com ([192.94.94.41]:36366 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753313Ab3H0QG7 (ORCPT ); Tue, 27 Aug 2013 12:06:59 -0400 In-Reply-To: <1377598305-15539-2-git-send-email-rnayak@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Rajendra Nayak Cc: tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcousson@baylibre.com On 08/27/2013 05:11 AM, Rajendra Nayak wrote: > Remove the empty am33xx_sram_init() function. > > Signed-off-by: Rajendra Nayak > --- > arch/arm/mach-omap2/sram.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/arm/mach-omap2/sram.c b/arch/arm/mach-omap2/sram.c > index 4bd0968..305fc2b 100644 > --- a/arch/arm/mach-omap2/sram.c > +++ b/arch/arm/mach-omap2/sram.c > @@ -285,11 +285,6 @@ static inline int omap34xx_sram_init(void) > } > #endif /* CONFIG_ARCH_OMAP3 */ > > -static inline int am33xx_sram_init(void) > -{ > - return 0; > -} > - > int __init omap_sram_init(void) > { > omap_detect_sram(); > @@ -299,8 +294,6 @@ int __init omap_sram_init(void) > omap242x_sram_init(); > else if (cpu_is_omap2430()) > omap243x_sram_init(); > - else if (soc_is_am33xx()) > - am33xx_sram_init(); > else if (cpu_is_omap34xx()) > omap34xx_sram_init(); > > Suspend resume for AM33xx as of right now uses this function. This patch [1] uses this function to push the low-level suspend code to sram, it was added here to be consistent with other platforms that utilize the same type of functionality (omap34xx). Regards, Dave [1] http://marc.info/?l=linux-omap&m=137581164813160&w=2 From mboxrd@z Thu Jan 1 00:00:00 1970 From: d-gerlach@ti.com (Dave Gerlach) Date: Tue, 27 Aug 2013 11:06:35 -0500 Subject: [PATCH 1/2] ARM: AM335x: Get rid of unused sram init function In-Reply-To: <1377598305-15539-2-git-send-email-rnayak@ti.com> References: <1377598305-15539-1-git-send-email-rnayak@ti.com> <1377598305-15539-2-git-send-email-rnayak@ti.com> Message-ID: <521CCE8B.4050907@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 08/27/2013 05:11 AM, Rajendra Nayak wrote: > Remove the empty am33xx_sram_init() function. > > Signed-off-by: Rajendra Nayak > --- > arch/arm/mach-omap2/sram.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/arm/mach-omap2/sram.c b/arch/arm/mach-omap2/sram.c > index 4bd0968..305fc2b 100644 > --- a/arch/arm/mach-omap2/sram.c > +++ b/arch/arm/mach-omap2/sram.c > @@ -285,11 +285,6 @@ static inline int omap34xx_sram_init(void) > } > #endif /* CONFIG_ARCH_OMAP3 */ > > -static inline int am33xx_sram_init(void) > -{ > - return 0; > -} > - > int __init omap_sram_init(void) > { > omap_detect_sram(); > @@ -299,8 +294,6 @@ int __init omap_sram_init(void) > omap242x_sram_init(); > else if (cpu_is_omap2430()) > omap243x_sram_init(); > - else if (soc_is_am33xx()) > - am33xx_sram_init(); > else if (cpu_is_omap34xx()) > omap34xx_sram_init(); > > Suspend resume for AM33xx as of right now uses this function. This patch [1] uses this function to push the low-level suspend code to sram, it was added here to be consistent with other platforms that utilize the same type of functionality (omap34xx). Regards, Dave [1] http://marc.info/?l=linux-omap&m=137581164813160&w=2