Re: [Qemu-devel] [PATCH] block: Remove redundant assertion

[Stefan Weil <sw@weilnetz.de>]

Am 27.08.2013 17:56, schrieb Kevin Wolf:
> The failing condition is checked immediately before the assertion, so
> keeping the assertion is kind of redundant.

Are you sure that it is not the check which is redundant?
Is file == NULL allowed in this 'else' branch?

Regards,
Stefan

>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  block.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/block.c b/block.c
> index a387c1a..26639e8 100644
> --- a/block.c
> +++ b/block.c
> @@ -743,7 +743,6 @@ static int bdrv_open_common(BlockDriverState *bs, BlockDriverState *file,
>              ret = -EINVAL;
>              goto free_and_fail;
>          }
> -        assert(file != NULL);
>          bs->file = file;
>          ret = drv->bdrv_open(bs, options, open_flags);
>      }