All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vikram Narayanan <vikram186@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
	dwmw2@infradead.org, dedekind1@gmail.com
Subject: Re: [PATCH V2 2/4] mtd: gpmi: use DMA channel 0 for all the nand chips
Date: Tue, 27 Aug 2013 22:35:25 +0530	[thread overview]
Message-ID: <521CDC55.60602@gmail.com> (raw)
In-Reply-To: <1377595747-21033-3-git-send-email-b32955@freescale.com>

On 27/Aug/2013 2:59 PM, Huang Shijie wrote:
> We only have one DMA channel : the channel 0.
> Use DMA channel 0 to access all the nand chips.

IIRC, We have 4 DMA channels. Don't we?

> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
>   drivers/mtd/nand/gpmi-nand/gpmi-nand.c |    5 ++---
>   1 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> index 8d8a814..24ee8d7 100644
> --- a/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> +++ b/drivers/mtd/nand/gpmi-nand/gpmi-nand.c
> @@ -357,9 +357,8 @@ int common_nfc_set_geometry(struct gpmi_nand_data *this)
>
>   struct dma_chan *get_dma_chan(struct gpmi_nand_data *this)
>   {
> -	int chipnr = this->current_chip;
> -
> -	return this->dma_chans[chipnr];
> +	/* We use the DMA channel 0 to access all the nand chips. */
> +	return this->dma_chans[0];
>   }
>
>   /* Can we use the upper's buffer directly for DMA? */
>

  reply	other threads:[~2013-08-27 17:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-27  9:29 [PATCH V2 0/4] mtd: gpmi: support two nand chips at most Huang Shijie
2013-08-27  9:29 ` [PATCH V2 1/4] mtd: gpmi: decouple the chip select from the DMA channel Huang Shijie
2013-08-27  9:29 ` [PATCH V2 2/4] mtd: gpmi: use DMA channel 0 for all the nand chips Huang Shijie
2013-08-27 17:05   ` Vikram Narayanan [this message]
2013-08-28  2:19     ` Huang Shijie
2013-08-27  9:29 ` [PATCH V2 3/4] mtd: gpmi: scan two " Huang Shijie
2013-08-27  9:29 ` [PATCH V2 4/4] mtd: gpmi: imx6: fix the wrong method for checking ready/busy Huang Shijie
2013-09-25  2:45 ` [PATCH V2 0/4] mtd: gpmi: support two nand chips at most Huang Shijie
2013-10-18  6:50 ` Huang Shijie
2013-10-19  2:01   ` Brian Norris
2013-10-21  3:40     ` Huang Shijie
2013-10-21  6:01       ` Gupta, Pekon
2013-10-21  8:32         ` Huang Shijie
2013-10-21  9:02           ` Gupta, Pekon
2013-10-22  8:16             ` Huang Shijie
2013-10-22  8:34               ` Sourav Poddar
2013-10-22  9:03                 ` Huang Shijie
2013-10-23 22:37       ` Brian Norris
2013-10-23 22:59 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521CDC55.60602@gmail.com \
    --to=vikram186@gmail.com \
    --cc=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.