Re: [PATCH 4/4] staging: ozwpan: Return error, if PD is not connected.

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 08/27/2013 07:53 PM, Rupesh Gujare wrote:

> Return error if we receive write(), while PD is not connected.

> Signed-off-by: Rupesh Gujare <rupesh.gujare@atmel.com>
> ---
>   drivers/staging/ozwpan/ozcdev.c |    2 ++
>   1 file changed, 2 insertions(+)

> diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
> index 03b41ee..22cb2ae 100644
> --- a/drivers/staging/ozwpan/ozcdev.c
> +++ b/drivers/staging/ozwpan/ozcdev.c
> @@ -162,6 +162,8 @@ static ssize_t oz_cdev_write(struct file *filp, const char __user *buf,
>   	spin_unlock_bh(&g_cdev.lock);
>   	if (pd == NULL)
>   		return -1;

    Note that returning -EPERM here is hardly correct.

> +	if (!(pd->state & OZ_PD_S_CONNECTED))
> +		return -ENXIO;

WBR, Sergei