From: Bart Van Assche <bvanassche-HInyCGIudOg@public.gmane.org>
To: "B.A.L.N.Raju Gottumukkala"
<B.A.L.NRaju.Gottumukkala-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org>
Cc: "bgottumukka-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org"
<bgottumukka-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH 02/14] RDMA/ocrdma: Add support for FRMR.
Date: Tue, 27 Aug 2013 20:29:08 +0200 [thread overview]
Message-ID: <521CEFF4.9010706@acm.org> (raw)
In-Reply-To: <6470282467066849AFF7BC0EABE2518C25FE5057-DWYeeINJQrxExQ8dmkPuX0M9+F4ksjoh@public.gmane.org>
Hello Naresh,
Good question. I'm not sure though what Roland prefers.
Bart.
On 08/27/13 16:33, B.A.L.N.Raju Gottumukkala wrote:
> Hi Bert,
>
> Sure I will change that.
>
> Some of the patches in this patch series will also get affected because of that.
>
> It will be easy for us to address that as a separate patch on top of this patch series. Does this sound Ok ?
>
> Thanks!!
> Naresh.
>
> -----Original Message-----
> From: Bart Van Assche [mailto:bvanassche-HInyCGIudOg@public.gmane.org]
> Sent: Monday, August 26, 2013 3:39 PM
> To: bgottumukka-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org
> Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org; B.A.L.N.Raju Gottumukkala
> Subject: Re: [PATCH 02/14] RDMA/ocrdma: Add support for FRMR.
>
> On 08/26/13 11:57, bgottumukka-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org wrote:
>> From: Naresh Gottumukkala <bgottumukkala-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>
>>
>> Also get the max_srq value from query_config mailbox response.
>>
>> Signed-off-by: Naresh Gottumukkala <bgottumukkala-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>
>
> There are already a few drivers upstream in which the fast register memory region work request is abbreviated as FRWR. Please consider renaming FRMR into FRWR in order to avoid confusion and in order to make it easier to find related code with grep in the kernel tree.
>
> Thanks,
>
> Bart.
>
> $ git grep -i '[^r]frwr' rdreier-infiniband/for-next | cat rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c:static __be64 frwr_mkey_mask(void) rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c:static void set_frwr_umr_segment(struct mlx5_wqe_umr_ctrl_seg *umr,
> rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c: umr->mkey_mask = frwr_mkey_mask();
> rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c:static void set_frwr_pages(struct mlx5_wqe_data_seg *dseg, rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c:static int set_frwr_li_wr(void **seg, struct ib_send_wr *wr, int *size,
> rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c: set_frwr_umr_segment(*seg, wr, li);
> rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c: set_frwr_pages(*seg, wr, mdev, pd, writ);
> rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c: err = set_frwr_li_wr(&seg, wr, &size, mdev, to_mpd(ibqp->pd), qp);
> rdreier-infiniband/for-next:drivers/infiniband/hw/mlx5/qp.c: err = set_frwr_li_wr(&seg, wr, &size, mdev, to_mpd(ibqp->pd), qp);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iscsi_iser.h: /* For fast registration - FRWR */
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iscsi_iser.h: } frwr;
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iscsi_iser.h:int iser_reg_rdma_mem_frwr(struct iscsi_iser_task *task, rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iscsi_iser.h:void iser_unreg_mem_frwr(struct iscsi_iser_task *iser_task, rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iscsi_iser.h:int iser_create_frwr_pool(struct iser_conn *ib_conn, unsigned cmds_max); rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iscsi_iser.h:void iser_free_frwr_pool(struct iser_conn *ib_conn);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_memory.c: * iser_reg_rdma_mem_frwr - Registers memory intended for RDMA, rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_memory.c:int iser_reg_rdma_mem_frwr(struct iscsi_iser_task *iser_task,
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_memory.c: desc = list_first_entry(&ib_conn->fastreg.frwr.pool,
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_memory.c: list_add_tail(&desc->list, &ib_conn->fastreg.frwr.pool);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: iser_info("FRWR supported, using FRWR for registration\n");
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: device->iser_alloc_rdma_reg_res = iser_create_frwr_pool;
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: device->iser_free_rdma_reg_res = iser_free_frwr_pool;
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: device->iser_reg_rdma_mem = iser_reg_rdma_mem_frwr;
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: device->iser_unreg_rdma_mem = iser_unreg_mem_frwr;
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: iser_err("IB device does not support FMRs nor FRWRs, can't register memory\n");
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: * iser_create_frwr_pool - Creates pool of fast_reg descriptors rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c:int iser_create_frwr_pool(struct iser_conn *ib_conn, unsigned cmds_max)
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: INIT_LIST_HEAD(&ib_conn->fastreg.frwr.pool);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: ib_conn->fastreg.frwr.pool_size = 0;
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: list_add_tail(&desc->list, &ib_conn->fastreg.frwr.pool);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: ib_conn->fastreg.frwr.pool_size++;
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: iser_free_frwr_pool(ib_conn);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: * iser_free_frwr_pool - releases the pool of fast_reg descriptors rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c:void iser_free_frwr_pool(struct iser_conn *ib_conn)
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: if (list_empty(&ib_conn->fastreg.frwr.pool))
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: iser_info("freeing conn %p frwr pool\n", ib_conn);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: list_for_each_entry_safe(desc, tmp, &ib_conn->fastreg.frwr.pool, list) {
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: if (i < ib_conn->fastreg.frwr.pool_size)
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: ib_conn->fastreg.frwr.pool_size - i);
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c:void iser_unreg_mem_frwr(struct iscsi_iser_task *iser_task,
> rdreier-infiniband/for-next:drivers/infiniband/ulp/iser/iser_verbs.c: list_add_tail(&desc->list, &ib_conn->fastreg.frwr.pool);
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-27 18:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1377511071-16967-1-git-send-email-bgottumukka@emulex.com>
[not found] ` <1377511071-16967-1-git-send-email-bgottumukka-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org>
2013-08-26 9:57 ` [PATCH 02/14] RDMA/ocrdma: Add support for FRMR bgottumukka-laKkSmNT4hbQT0dZR+AlfA
[not found] ` <2eee7e35-504e-4f2a-a364-527e90669108-3RiH6ntJJkP8BX6JNMqfyFjyZtpTMMwT@public.gmane.org>
2013-08-26 10:08 ` Bart Van Assche
[not found] ` <6470282467066849AFF7BC0EABE2518C25FE5057@CMEXMB1.ad.emulex.com>
[not found] ` <6470282467066849AFF7BC0EABE2518C25FE5057-DWYeeINJQrxExQ8dmkPuX0M9+F4ksjoh@public.gmane.org>
2013-08-27 18:29 ` Bart Van Assche [this message]
[not found] ` <521CEFF4.9010706-HInyCGIudOg@public.gmane.org>
2013-08-28 6:10 ` Roland Dreier
2013-08-26 9:57 ` [PATCH 03/14] RDMA/ocrdma: Removed the mtu check based eth mtu bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 04/14] RDMA/ocrdma: Fix to work with even single msix vector bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 05/14] RDMA/ocrdma: For ERX2 irrespective of Qid, num_posted offset is 24 bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 06/14] RDMA/ocrdma: FRMA code cleanup bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 07/14] RDMA/ocrdma: Dont use PD 0 for usepace CQ DB bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 08/14] RDMA/ocrdma: Add support for reg_phys_mr bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 09/14] RDMA/ocrdma: Increate STAG array size bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 10/14] RDMA/ocrdma: Fix for displaying proper link speed bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 11/14] RDMA/ocrdma: Consider multiple SGES in case of DPP bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 12/14] RDMA/ocrdma: Added ABI versioning support bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 13/14] RDMA/ocrdma: Fill PVID in UMC case bgottumukka-laKkSmNT4hbQT0dZR+AlfA
2013-08-26 9:57 ` [PATCH 14/14] RDMA/ocrdma: Fix passing wrong opcode to modify_srq bgottumukka-laKkSmNT4hbQT0dZR+AlfA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521CEFF4.9010706@acm.org \
--to=bvanassche-hinycgiudog@public.gmane.org \
--cc=B.A.L.NRaju.Gottumukkala-iH1Dq9VlAzfQT0dZR+AlfA@public.gmane.org \
--cc=bgottumukka-laKkSmNT4hbQT0dZR+AlfA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.