From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58021)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <James.Hogan@imgtec.com>) id 1VEb41-0006rY-PD
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:25:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <James.Hogan@imgtec.com>) id 1VEb3w-00080g-SB
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:25:17 -0400
Received: from multi.imgtec.com ([194.200.65.239]:1133)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <James.Hogan@imgtec.com>) id 1VEb3w-00080V-M6
	for qemu-devel@nongnu.org; Wed, 28 Aug 2013 04:25:12 -0400
Message-ID: <521DB3E3.1040404@imgtec.com>
Date: Wed, 28 Aug 2013 09:25:07 +0100
From: James Hogan <james.hogan@imgtec.com>
MIME-Version: 1.0
References: <1377619333-16062-1-git-send-email-james.hogan@imgtec.com>
	<521CF27A.1070607@twiddle.net>
In-Reply-To: <521CF27A.1070607@twiddle.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] qemu: Fix cross compilation for mipsel
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: Sanjay Lal <sanjayl@kymasys.com>, Mike Frysinger <vapier@gentoo.org>, qemu-devel@nongnu.org, =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>

On 27/08/13 19:39, Richard Henderson wrote:
> On 08/27/2013 09:02 AM, James Hogan wrote:
>> The configure script was setting HOST_WORDS_BIGENDIAN for all $cpu =
>> mips|mips64 when cross compiling, since endianness cannot be detected by
>> running a test program. This includes little endian MIPS though. It
>> didn't cause any build errors but does prevent QEMU from working
>> correctly. Instead, detect the endianness similar to how we do for ARM,
>> by checking for the __MIPSEB__ builtin processor definition.
>>
>> This is from a hunk in the "[PATCH 8/12] KVM/MIPS: Enable KVM/MIPS for
>> MIPS targets. Add MIPS GIC code to the build" patch by Sanjay Lal [1].
> 
> Redundant with Mike Frysinger's more general patch,
> 
> http://patchwork.ozlabs.org/patch/256001/

Even better. Thanks for pointing that out. I've added my tested-by.

Cheers
James