From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH] V4 pci uart - better cope with UART being
 temporarily unavailable
Date: Wed, 28 Aug 2013 12:15:26 +0100
Message-ID: <521DDBCE.70800@linaro.org>
References: <1377612358-13249-1-git-send-email-tomasz.wroblewski@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1377612358-13249-1-git-send-email-tomasz.wroblewski@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tomasz Wroblewski <tomasz.wroblewski@citrix.com>
Cc: keir@xen.org, Ian Campbell <Ian.Campbell@citrix.com>, JBeulich@suse.com, xen-devel@lists.xen.org
List-Id: xen-devel@lists.xenproject.org

On 08/27/2013 03:05 PM, Tomasz Wroblewski wrote:
> diff --git a/xen/include/xen/serial.h b/xen/include/xen/serial.h
> index 403e193..f38c9b7 100644
> --- a/xen/include/xen/serial.h
> +++ b/xen/include/xen/serial.h
> @@ -70,8 +70,9 @@ struct uart_driver {
>      /* Driver suspend/resume. */
>      void (*suspend)(struct serial_port *);
>      void (*resume)(struct serial_port *);
> -    /* Return number of characters the port can hold for transmit. */
> -    unsigned int (*tx_ready)(struct serial_port *);
> +    /* Return number of characters the port can hold for transmit,
> +     * or -EIO if port is inaccesible */
> +    int (*tx_ready)(struct serial_port *);

Hi,

This callback is shared between ARM and X86. You forgot to modify ARM UART =
driver
(omap, pl011, exynos4210,...), so it breaks Xen unstable compilation on ARM.

pl011.c:209:5: error: initialization from incompatible pointer type [-Werro=
r]
     .tx_ready     =3D pl011_tx_ready,
     ^
pl011.c:209:5: error: (near initialization for =91pl011_driver.tx_ready=92)=
 [-Werror]
exynos4210-uart.c:298:5: error: initialization from incompatible pointer ty=
pe [-Werror]
     .tx_ready     =3D exynos4210_uart_tx_ready,
     ^
exynos4210-uart.c:298:5: error: (near initialization for =91exynos4210_uart=
_driver.tx_ready=92) [-Werror]
omap-uart.c:285:5: error: initialization from incompatible pointer type [-W=
error]
     .tx_ready =3D omap_uart_tx_ready,
     ^

Please, send a patch to fix the compilation on ARM.

Thanks


-- =

Julien Grall