Re: [Qemu-devel] [PATCH 1/3] block: Image file option amendment

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 940 bytes --]

On 08/28/2013 02:08 AM, Max Reitz wrote:
> This patch adds the "amend" option to qemu-img which allows changing
> image options on existing image files. It also adds the generic bdrv
> implementation which is basically just a wrapper for the image format
> specific function.
> 

> +
> +@item amend [-f @var{fmt}] -o @var{options} @var{filename}
> +
> +Amends the image format specific @var{options} for the image file
> +@var{filename}. Only the format @code{qcow2} supports this.

The flattening of implicit zero clusters into explicit may take a
significant amount of time; please consider adding support for -p
(progress meter) as part of this addition.  (I'm already bothered by the
fact that the 'commit' operation lacks a progress meter; and even
'check' might have cases where it could be long-running)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]