From: Jason Wessel <jason.wessel@windriver.com>
To: "Peter A. Bigot" <pab@pabigot.com>
Cc: bitbake-devel <bitbake-devel@lists.openembedded.org>
Subject: Re: [PATCH] bitbake: server/xmlrpc/prserv: Increase timeout to default xmlrpc server
Date: Wed, 28 Aug 2013 08:39:58 -0500 [thread overview]
Message-ID: <521DFDAE.5040507@windriver.com> (raw)
In-Reply-To: <1377695062-16111-1-git-send-email-pab@pabigot.com>
On 08/28/2013 08:04 AM, Peter A. Bigot wrote:
> On a heavily-loaded host with local PR server the default 5 second timeout
> produces too-frequent errors:
>
> ERROR: Can NOT get PRAUTO, exception timed out
> ERROR: Function failed: package_get_auto_pr
>
> Since this error aborts the build a generous timeout seems appropriate.
>
> Signed-off-by: Peter A. Bigot <pab@pabigot.com>
> ---
> lib/bb/server/xmlrpc.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/bb/server/xmlrpc.py b/lib/bb/server/xmlrpc.py
> index 4dee5d9..bb87fd7 100644
> --- a/lib/bb/server/xmlrpc.py
> +++ b/lib/bb/server/xmlrpc.py
> @@ -78,7 +78,7 @@ class BBTransport(xmlrpclib.Transport):
> h.putheader("Bitbake-token", self.connection_token)
> xmlrpclib.Transport.send_content(self, h, body)
>
> -def _create_server(host, port, timeout = 5):
> +def _create_server(host, port, timeout = 20):
> t = BBTransport(timeout)
> s = xmlrpclib.Server("http://%s:%d/" % (host, port), transport=t, allow_none=True)
> return s, t
I would go so far as to make this 60 seconds and or have it a configurable parameter.
Previously the timeout was infinite. I have observed process creation lagging by 30-45 seconds on a server with a load average of +300. The new bitbake python code with the reduced timeout is not yet running on our edge case testing environment, but I do expect to hit the same issue.
Jason.
next prev parent reply other threads:[~2013-08-28 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 13:04 [PATCH] bitbake: server/xmlrpc/prserv: Increase timeout to default xmlrpc server Peter A. Bigot
2013-08-28 13:39 ` Jason Wessel [this message]
2013-08-28 13:59 ` Peter A. Bigot
2013-08-29 13:38 ` Richard Purdie
2013-08-29 17:06 ` Peter A. Bigot
2013-08-30 16:43 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521DFDAE.5040507@windriver.com \
--to=jason.wessel@windriver.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=pab@pabigot.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.