All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chen Gang <gang.chen@asianux.com>
To: Yoshinori Sato <ysato@users.sourceforge.jp>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	ak@linux.intel.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] h8300/kernel/timer/timer8.c: add the missing semicolon
Date: Thu, 29 Aug 2013 12:44:37 +0800	[thread overview]
Message-ID: <521ED1B5.5030507@asianux.com> (raw)
In-Reply-To: <521EC55A.9030905@asianux.com>

On 08/29/2013 11:51 AM, Chen Gang wrote:
> Add the missing semicolon to fix the typo issue.
> 
> The related error: (defconfig for H8S):
> 
>   arch/h8300/kernel/timer/timer8.c: In function 'h8300_timer_setup':
>   arch/h8300/kernel/timer/timer8.c:98:2: error: expected ';' before 'ctrl_outw'
> 
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
> ---
>  arch/h8300/Makefile              |    2 +-
>  arch/h8300/kernel/timer/timer8.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/h8300/Makefile b/arch/h8300/Makefile
> index a556447..d2ba710 100644
> --- a/arch/h8300/Makefile
> +++ b/arch/h8300/Makefile
> @@ -25,7 +25,7 @@ model-$(CONFIG_RAMKERNEL)	:= ram
>  model-$(CONFIG_ROMKERNEL)	:= rom
>  MODEL := $(model-y)
>  
> -cflags-$(CONFIG_CPU_H8300H)	:= -mh
> +cflags-$(CONFIG_CPU_H8300H)	:= -mh -mcpu=h8300h

Oh, sorry, it contents some waste things, I should send patch v2.


>  ldflags-$(CONFIG_CPU_H8300H)	:= -mh8300helf
>  cflags-$(CONFIG_CPU_H8S)	:= -ms
>  ldflags-$(CONFIG_CPU_H8S)	:= -mh8300self
> diff --git a/arch/h8300/kernel/timer/timer8.c b/arch/h8300/kernel/timer/timer8.c
> index 505f341..8aac2a7 100644
> --- a/arch/h8300/kernel/timer/timer8.c
> +++ b/arch/h8300/kernel/timer/timer8.c
> @@ -91,7 +91,7 @@ void __init h8300_timer_setup(void)
>  
>  #if defined(CONFIG_CPU_H8S)
>  	/* Timer module enable */
> -	ctrl_bclr(0, MSTPCRL)
> +	ctrl_bclr(0, MSTPCRL);
>  #endif
>  
>  	/* initialize timer */
> 


-- 
Chen Gang

  reply	other threads:[~2013-08-29  4:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29  3:51 [PATCH] h8300/kernel/timer/timer8.c: add the missing semicolon Chen Gang
2013-08-29  4:44 ` Chen Gang [this message]
2013-08-29  4:47 ` [PATCH v2] " Chen Gang
2013-08-29  9:42   ` [PATCH] drivers: ide: Kconfig: let IDE_H8300 depends on H8300H_AKI3068NET or H8300H_H8MAX Chen Gang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=521ED1B5.5030507@asianux.com \
    --to=gang.chen@asianux.com \
    --cc=ak@linux.intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.