From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <shijie8@gmail.com>
Cc: Huang Shijie <b32955@freescale.com>,
linux-mtd@lists.infradead.org, dwmw2@infradead.org,
dedekind1@gmail.com
Subject: Re: [PATCH v3 06/10] mtd: fix the wrong mtd->type for nand chip
Date: Wed, 28 Aug 2013 22:05:35 -0700 [thread overview]
Message-ID: <521ED69F.5080203@gmail.com> (raw)
In-Reply-To: <20130829012403.GA4254@gmail.com>
On 08/28/2013 06:24 PM, Huang Shijie wrote:
> On Wed, Aug 28, 2013 at 12:28:51AM -0700, Brian Norris wrote:
>> On 08/27/2013 11:59 PM, Huang Shijie wrote:
>>
>> Yes, I saw that.
>>
>>> That's why we should expose the MTD_MLCNANDFLASH to the user-space
>>
>> All you've shown is the breakage, not the reason for exposing
>> MTD_MLCNANFLASH. There's a difference between MTD_MLCNANDFLASH being
> Do you mean this patch exposes the MTD_MLCNANDFLASH to user space?
> or the patch 8 exposes the MTD_MLCNANDFLASH to user space?
This patch (patch 6) changes the mtd->type for MLC NAND. And mtd->type
is exposed to user-space via ioctl(MEMGETINFO), and (as of this patch),
it is exposed as "unknown" in sysfs.
Patch 8 only changes the "unknown" to "mlc-nand"---an improvement, but
patch 6 is still the first one that makes a visible change to the ABI.
Brian
next prev parent reply other threads:[~2013-08-29 5:06 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 9:36 [PATCH v3 00/10] About the SLC/MLC Huang Shijie
2013-08-26 9:36 ` [PATCH v3 01/10] mtd: nand: rename the cellinfo to bits_per_cell Huang Shijie
2013-08-27 17:10 ` Vikram Narayanan
2013-08-28 2:23 ` Huang Shijie
2013-08-28 2:42 ` Brian Norris
2013-08-28 2:45 ` Huang Shijie
2013-08-28 2:48 ` Brian Norris
2013-08-28 2:53 ` Huang Shijie
2013-08-28 3:02 ` Brian Norris
2013-08-28 3:09 ` Huang Shijie
2013-08-26 9:36 ` [PATCH v3 02/10] mtd: set the cell information for ONFI nand Huang Shijie
2013-08-26 9:36 ` [PATCH v3 03/10] mtd: print out the cell information for nand chip Huang Shijie
2013-08-26 9:36 ` [PATCH v3 04/10] mtd: gpmi: rewrite the gpmi_ecc_write_oob() to support the jffs2 Huang Shijie
2013-08-26 9:36 ` [PATCH v3 05/10] mtd: add more comment for MTD_NANDFLASH/MTD_MLCNANDFLASH Huang Shijie
2013-08-26 9:36 ` [PATCH v3 06/10] mtd: fix the wrong mtd->type for nand chip Huang Shijie
2013-08-28 3:08 ` Brian Norris
2013-08-28 6:59 ` Huang Shijie
2013-08-28 7:28 ` Brian Norris
2013-08-28 7:50 ` Huang Shijie
2013-08-28 9:26 ` Huang Shijie
2013-08-29 1:24 ` Huang Shijie
2013-08-29 5:05 ` Brian Norris [this message]
2013-08-29 5:34 ` Huang Shijie
2013-08-29 5:50 ` Huang Shijie
2013-09-04 18:51 ` Brian Norris
[not found] ` <52280278.6020007@freescale.com>
2013-09-17 0:13 ` Brian Norris
2013-08-26 9:36 ` [PATCH v3 07/10] jffs2: do not support the MLC nand Huang Shijie
2013-08-26 9:36 ` [PATCH v3 08/10] mtd: add MTD_MLCNANDFLASH case for mtd_type_show() Huang Shijie
2013-08-26 9:36 ` [PATCH v3 09/10] mtd: add a helper to detect the nand type Huang Shijie
2013-09-17 0:27 ` Brian Norris
2013-08-26 9:36 ` [PATCH v3 10/10] mtd: mtd-abi: " Huang Shijie
2013-08-26 12:41 ` [PATCH v3 00/10] About the SLC/MLC Thomas Petazzoni
2013-08-27 3:30 ` Huang Shijie
2013-10-19 13:32 ` Ezequiel Garcia
2013-10-21 2:58 ` Huang Shijie
2013-10-22 5:11 ` Gupta, Pekon
2013-10-30 22:02 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521ED69F.5080203@gmail.com \
--to=computersforpeace@gmail.com \
--cc=b32955@freescale.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shijie8@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.