From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VEuoR-00049X-0c for qemu-devel@nongnu.org; Thu, 29 Aug 2013 01:30:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VEuoJ-0004Gs-Fk for qemu-devel@nongnu.org; Thu, 29 Aug 2013 01:30:30 -0400 Message-ID: <521EDC6A.4020401@suse.de> Date: Thu, 29 Aug 2013 07:30:18 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1376606111-3518-1-git-send-email-afaerber@suse.de> <1376606111-3518-3-git-send-email-afaerber@suse.de> <521ECE43.1090401@ozlabs.ru> In-Reply-To: <521ECE43.1090401@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 2/4] spapr: Use DeviceClass::fw_name for device tree CPU node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Prerna Saxena , qemu-ppc , qemu-devel@nongnu.org, Alexander Graf Am 29.08.2013 06:29, schrieb Alexey Kardashevskiy: > On 08/16/2013 08:35 AM, Andreas F=C3=A4rber wrote: >> Instead of relying on cpu_model, obtain the device tree node label >> per CPU. Use DeviceClass::fw_name when available. This implicitly >> resolves HOST@0 node labels for those CPUs through inheritance. >> >> Whenever DeviceClass::fw_name is not available, derive it from the CPU= 's >> type name and fill it in for that class with a "PowerPC," prefix for >> PAPR compliance. >=20 >=20 > I'd rather use the family's @desc instead of CPU class name, would be > simpler and we would not have nodes like "PowerPC,POWER7-family@0" (thi= s is > what I get when comment out dc->fw_name for power7 with my PVR patch, j= ust > to test). Negative, desc is a free-text field and may contain spaces, parenthesis, etc. Each model may set desc differently btw, so given my change request for the comparison, we might end up with "POWER7 v2.1" on that particular PVR. > Either way, in what case do you expect that code to work at all? power7= , > 7+, 8 have fw_name field initialized, what else is really supported for > spapr and requires this workaround? 970 comes to mind? Anyway, this was just a more direct way to address the issues raised by Prerna. If you guys don't see the need to enforce these naming rules beyond a supported list of POWER CPUs then we can strip it down further, possibly falling back to a fixed "PowerPC,UNKNOWN" rather than trying to construct a name. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg