From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41184)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VEy7n-0002Uf-6X
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 05:02:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1VEy7c-0000RB-Oc
	for qemu-devel@nongnu.org; Thu, 29 Aug 2013 05:02:43 -0400
Message-ID: <521F0E24.80009@suse.de>
Date: Thu, 29 Aug 2013 11:02:28 +0200
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1377735229-54669-1-git-send-email-agraf@suse.de>
In-Reply-To: <1377735229-54669-1-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] PPC: KVM: Compile fix for qemu_notify_event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: qemu-ppc <qemu-ppc@nongnu.org>, qemu-devel <qemu-devel@nongnu.org>

Am 29.08.2013 02:13, schrieb Alexander Graf:
> The function qemu_notify_event is defined by a header that we don't
> include in the PPC KVM code. Include it to get the code building
> again.
>=20
>   target-ppc/kvm_ppc.c: In function 'kvmppc_timer_hack':
>   target-ppc/kvm_ppc.c:26:5: error: implicit declaration of function 'q=
emu_notify_event' [-Werror=3Dimplicit-function-declaration]
>   target-ppc/kvm_ppc.c:26:5: error: nested extern declaration of 'qemu_=
notify_event' [-Werror=3Dnested-externs]
>=20
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  target-ppc/kvm_ppc.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/target-ppc/kvm_ppc.c b/target-ppc/kvm_ppc.c
> index 9b83655..f769acd 100644
> --- a/target-ppc/kvm_ppc.c
> +++ b/target-ppc/kvm_ppc.c
> @@ -15,6 +15,7 @@
>  #include "qemu/timer.h"
>  #include "kvm_ppc.h"
>  #include "sysemu/device_tree.h"
> +#include "qemu/main-loop.h"
> =20
>  #define PROC_DEVTREE_PATH "/proc/device-tree"
> =20

Matches my local fix, so

Tested-by: Andreas F=E4rber <afaerber@suse.de>

but I didn't find out yet who/what broke this, since the
qemu_notify_event() line hasn't changed in a long time according to
git-blame...

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg