From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [RFC] x86/hpet: Correct -ENOMEM actions in hpet_fsb_cap_lookup()
Date: Thu, 29 Aug 2013 11:14:48 +0100 [thread overview]
Message-ID: <521F1F18.6050303@citrix.com> (raw)
In-Reply-To: <521F106202000078000EF4D6@nat28.tlf.novell.com>
On 29/08/13 08:12, Jan Beulich wrote:
>>
>> This patch is RFC as I didn't actually encounter the problem, nor can think of
>> an easy way of actually testing the correctness of the codepath. Chances are
>> that if -ENOMEM occurs here, Xen is not actually going to complete booting.
> And you're turning a success case (just using fewer than the
> available channels) into an error one - it was intentionally coded
> this way, and only if there's a problem with that logic I'd consider
> a patch valid.
>
> Jan
>
Ah - I had not appreciated that possibility, which does make sense.
~Andrew
prev parent reply other threads:[~2013-08-29 10:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-28 16:55 [RFC] x86/hpet: Correct -ENOMEM actions in hpet_fsb_cap_lookup() Andrew Cooper
2013-08-29 7:12 ` Jan Beulich
2013-08-29 10:14 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F1F18.6050303@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.