From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Fabio Estevam <fabio.estevam@freescale.com>,
alsa-devel@alsa-project.org, shawn.guo@linaro.org,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [RFC] ASoC: soc-pcm: Add support for unidirectional dai links
Date: Thu, 29 Aug 2013 12:53:41 +0200 [thread overview]
Message-ID: <521F2835.4060109@metafoo.de> (raw)
In-Reply-To: <20130829104742.GU10783@sirena.org.uk>
On 08/29/2013 12:47 PM, Mark Brown wrote:
> On Thu, Aug 29, 2013 at 01:54:59AM -0300, Fabio Estevam wrote:
>
>> @@ -105,11 +105,13 @@ static struct snd_soc_dai_link mxs_sgtl5000_dai[] = {
>> .stream_name = "HiFi Playback",
>> .codec_dai_name = "sgtl5000",
>> .ops = &mxs_sgtl5000_hifi_ops,
>> + .playback_only = true,
>> }, {
>> .name = "HiFi Rx",
>> .stream_name = "HiFi Capture",
>> .codec_dai_name = "sgtl5000",
>> .ops = &mxs_sgtl5000_hifi_ops,
>> + .capture_only = true,
>> },
>
> This doesn't make much sense to me - it should be possible to tell from
> the capabilities of the two DAIs on the link if they support both
> playback and capture. Or has the board wired up two bidirectional DAIs
> on each link for some reason?
>
The MXS DAIs are unidirectional, but the direction can be configured at
runtime. The alternative here is to specify the direction at driver probe
time instead of in the dai_link.
next prev parent reply other threads:[~2013-08-29 10:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 4:54 [RFC] ASoC: soc-pcm: Add support for unidirectional dai links Fabio Estevam
2013-08-29 10:47 ` Mark Brown
2013-08-29 10:53 ` Lars-Peter Clausen [this message]
2013-08-29 11:45 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F2835.4060109@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.estevam@freescale.com \
--cc=festevam@gmail.com \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.