Re: [PATCH 2/3] thermal: exynos: Fix potential NULL pointer dereference

[Eduardo Valentin <eduardo.valentin@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 1710 bytes --]

On 19-08-2013 02:28, Sachin Kamat wrote:
> NULL pointer was being dereferenced in its own error message.
> Changed it to the correct device pointer.
> 
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>


Acked-by: Eduardo Valentin <eduardo.valentin@ti.com>

> ---
>  drivers/thermal/samsung/exynos_thermal_common.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/samsung/exynos_thermal_common.c b/drivers/thermal/samsung/exynos_thermal_common.c
> index 4d8e444..f10a6ad 100644
> --- a/drivers/thermal/samsung/exynos_thermal_common.c
> +++ b/drivers/thermal/samsung/exynos_thermal_common.c
> @@ -53,7 +53,7 @@ static int exynos_set_mode(struct thermal_zone_device *thermal,
>  {
>  	struct exynos_thermal_zone *th_zone = thermal->devdata;
>  	if (!th_zone) {
> -		dev_err(th_zone->sensor_conf->dev,
> +		dev_err(&thermal->device,
>  			"thermal zone not registered\n");
>  		return 0;
>  	}
> @@ -231,7 +231,7 @@ static int exynos_get_temp(struct thermal_zone_device *thermal,
>  	void *data;
>  
>  	if (!th_zone->sensor_conf) {
> -		dev_err(th_zone->sensor_conf->dev,
> +		dev_err(&thermal->device,
>  			"Temperature sensor not initialised\n");
>  		return -EINVAL;
>  	}
> @@ -251,7 +251,7 @@ static int exynos_set_emul_temp(struct thermal_zone_device *thermal,
>  	struct exynos_thermal_zone *th_zone = thermal->devdata;
>  
>  	if (!th_zone->sensor_conf) {
> -		dev_err(th_zone->sensor_conf->dev,
> +		dev_err(&thermal->device,
>  			"Temperature sensor not initialised\n");
>  		return -EINVAL;
>  	}
> 


-- 
You have got to be excited about what you are doing. (L. Lamport)

Eduardo Valentin


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 295 bytes --]