Re: [Qemu-devel] [RFC][PATCH 4/6] qmp: add 'cpu-del' command support

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1287 bytes --]

On 08/28/2013 08:09 PM, Chen Fan wrote:
> Signed-off-by: Chen Fan <chen.fan.fnst@cn.fujitsu.com>
> ---
>  hw/i386/pc.c         |  5 +++++
>  hw/i386/pc_piix.c    |  1 +
>  include/hw/boards.h  |  2 ++
>  include/hw/i386/pc.h |  1 +
>  qapi-schema.json     | 12 ++++++++++++
>  qmp-commands.hx      | 23 +++++++++++++++++++++++
>  qmp.c                |  9 +++++++++
>  7 files changed, 53 insertions(+)
> 
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index c0e7cbd..75fc9bb 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -958,6 +958,11 @@ void pc_hot_add_cpu(const int64_t id, Error **errp)
>      pc_new_cpu(current_cpu_model, apic_id, icc_bridge, errp);
>  }
>  
> +void pc_hot_del_cpu(const int64_t id, Error **errp)
> +{
> +    /* TODO: hot remove VCPU. */
> +}

That seems fishy.


> +++ b/qapi-schema.json
> @@ -1432,6 +1432,18 @@
>  ##
>  { 'command': 'cpu-add', 'data': {'id': 'int'} }
>  
> +# @cpu-del
> +
> +# Deletes CPU with specified ID
> +#
> +# @id: ID of CPU to be deleted, valid values [0..max_cpus)
> +#
> +# Returns: Nothing on success
> +#
> +# Since 1.6

1.6 is already out the door.  This must be 1.7.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]