From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qcow2-refcount: Snapshot update for zero clusters
Date: Thu, 29 Aug 2013 06:30:47 -0600 [thread overview]
Message-ID: <521F3EF7.1070303@redhat.com> (raw)
In-Reply-To: <1377771363-5198-1-git-send-email-mreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 413 bytes --]
On 08/29/2013 04:16 AM, Max Reitz wrote:
> Do not try to update the refcount for zero clusters in
> qcow2_update_snapshot_refcount.
Why? What does this fix?
(Hint - your commit message could use more details, and you should add a
testsuite addition that exposes the case that you are fixing)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-08-29 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 10:16 [Qemu-devel] [PATCH] qcow2-refcount: Snapshot update for zero clusters Max Reitz
2013-08-29 12:30 ` Eric Blake [this message]
2013-08-29 12:35 ` Max Reitz
2013-08-29 12:33 ` Kevin Wolf
2013-08-29 12:38 ` Max Reitz
2013-08-29 12:53 ` Kevin Wolf
2013-08-29 12:56 ` Max Reitz
2013-08-29 13:04 ` Kevin Wolf
2013-08-29 13:06 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F3EF7.1070303@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.