From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 29 Aug 2013 14:54:15 +0200 (CEST) Received: from multi.imgtec.com ([194.200.65.239]:29745 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822678Ab3H2MyIdrViU (ORCPT ); Thu, 29 Aug 2013 14:54:08 +0200 Message-ID: <521F4469.6020507@imgtec.com> Date: Thu, 29 Aug 2013 13:54:01 +0100 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Florian Fainelli CC: , , , Subject: Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT References: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com> In-Reply-To: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com> X-Enigmail-Version: 1.5.2 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01192__2013_08_29_13_54_02 Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37706 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: james.hogan@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips Hi Florian, On 28/08/13 16:42, Florian Fainelli wrote: > +ifdef CONFIG_SYS_SUPPORTS_ZBOOT > # boot/compressed > vmlinuz vmlinuz.bin vmlinuz.ecoff vmlinuz.srec: $(vmlinux-32) FORCE > $(Q)$(MAKE) $(build)=arch/mips/boot/compressed \ > VMLINUX_LOAD_ADDRESS=$(load-y) 32bit-bfd=$(32bit-bfd) $@ > +else > +vmlinuz: Does this need a dependency on FORCE so that if you switched config and had a valid vmlinuz lying around it doesn't do nothing as a result of vmlinuz having no dependencies and existing? > + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled' Also it may be worth adding false here too so that make's exit code reports failure correctly. Cheers James From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from multi.imgtec.com ([194.200.65.239]:29745 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S6822678Ab3H2MyIdrViU (ORCPT ); Thu, 29 Aug 2013 14:54:08 +0200 Message-ID: <521F4469.6020507@imgtec.com> Date: Thu, 29 Aug 2013 13:54:01 +0100 From: James Hogan MIME-Version: 1.0 Subject: Re: [PATCH] MIPS: do not allow building vmlinuz when !ZBOOT References: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com> In-Reply-To: <1377704569-21331-1-git-send-email-f.fainelli@gmail.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: Florian Fainelli Cc: linux-mips@linux-mips.org, ralf@linux-mips.org, blogic@openwrt.org, richard@nod.at Message-ID: <20130829125401.gaAaE7dVorm3tioariLAztlAUcpa9YbejJcUR5aahYQ@z> Hi Florian, On 28/08/13 16:42, Florian Fainelli wrote: > +ifdef CONFIG_SYS_SUPPORTS_ZBOOT > # boot/compressed > vmlinuz vmlinuz.bin vmlinuz.ecoff vmlinuz.srec: $(vmlinux-32) FORCE > $(Q)$(MAKE) $(build)=arch/mips/boot/compressed \ > VMLINUX_LOAD_ADDRESS=$(load-y) 32bit-bfd=$(32bit-bfd) $@ > +else > +vmlinuz: Does this need a dependency on FORCE so that if you switched config and had a valid vmlinuz lying around it doesn't do nothing as a result of vmlinuz having no dependencies and existing? > + @echo ' CONFIG_SYS_SUPPORTS_ZBOOT is not enabled' Also it may be worth adding false here too so that make's exit code reports failure correctly. Cheers James