From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57720) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4Mm-0000Pb-BI for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:42:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VF4Mg-0001Yv-Cf for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:42:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33420) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VF4Mg-0001Yg-4U for qemu-devel@nongnu.org; Thu, 29 Aug 2013 11:42:30 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r7TFgReg008997 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 29 Aug 2013 11:42:28 -0400 Message-ID: <521F6BDF.5070008@redhat.com> Date: Thu, 29 Aug 2013 17:42:23 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <521F4E76.2090507@redhat.com> <1377783470-8981-2-git-send-email-lersek@redhat.com> <521F53A6.7070200@redhat.com> <521F581A.50301@redhat.com> <521F607F.70001@redhat.com> <521F6A3C.5060702@redhat.com> In-Reply-To: <521F6A3C.5060702@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] add some virtio-scsi trace events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: qemu-devel@nongnu.org Il 29/08/2013 17:35, Laszlo Ersek ha scritto: > On 08/29/13 16:53, Paolo Bonzini wrote: >> I'll try to salvage the patch. > > I won't bother next time. I wouldn't want you to waste your time on > "salvaging" the clearly broken patches that I submit. WTF? The patch is clearly a good thing, or I wouldn't have asked you to send it. However, if you don't have time to follow up on my comments, all that a maintainer can do is: (1) ignore it and/or let it rot (2) pick it up and gain something from a patch that isn't quite ready. #2 is exactly the definition of salvage. > To be clear, I considered this series a favor. Sure, and it's very welcome. But you shouldn't expect too much from your interlocutor after writing "I don't have any more time for this". If you don't have any more time for this, next time send me the patch privately and say it in advance before I even start reviewing it. I'll make sure you're properly acknowledged with From and Signed-off-by headers. Paolo, glad that this time he's on the receiving edge of a flame...