From: Wladislav Wiebe <wladislav.kw@gmail.com>
To: Grant Likely <grant.likely@linaro.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] of/fdt: Remove duplicate memory clearing on FDT unflattening
Date: Thu, 29 Aug 2013 18:47:00 +0200 [thread overview]
Message-ID: <521F7B04.6040200@gmail.com> (raw)
In-Reply-To: <1377783892-13226-1-git-send-email-grant.likely@linaro.org>
On 29/08/13 15:44, Grant Likely wrote:
> Patch 9e4012752, "of: fdt: fix memory initialization for expanded DT"
> fixed incomplete clearing of memory when unflattening the device tree.
> However the code was already clearing some of the memory, it just wasn't
> doing so for all allocations. Now that the memory is cleared right at
> the point of allocation, the memset after unflatten_dt_alloc() is
> redundant. Remove it.
Acked-by: Wladislav Wiebe <wladislav.kw@gmail.com>
>
> Signed-off-by: Grant Likely <grant.likely@linaro.org>
> Cc: Wladislav Wiebe <wladislav.kw@gmail.com>
> ---
> drivers/of/fdt.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
> index 55b028f..9d9be9617 100644
> --- a/drivers/of/fdt.c
> +++ b/drivers/of/fdt.c
> @@ -202,7 +202,6 @@ static void * unflatten_dt_node(struct boot_param_header *blob,
> __alignof__(struct device_node));
> if (allnextpp) {
> char *fn;
> - memset(np, 0, sizeof(*np));
> np->full_name = fn = ((char *)np) + sizeof(*np);
> if (new_format) {
> /* rebuild full path for new format */
>
prev parent reply other threads:[~2013-08-29 16:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 13:44 [PATCH] of/fdt: Remove duplicate memory clearing on FDT unflattening Grant Likely
2013-08-29 16:47 ` Wladislav Wiebe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521F7B04.6040200@gmail.com \
--to=wladislav.kw@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.