From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH v2 3/3] ARM: OMAP4+: Remove static iotable mappings for SRAM Date: Thu, 29 Aug 2013 13:25:04 -0400 Message-ID: <521F83F0.9080503@ti.com> References: <1377775391-13103-1-git-send-email-rnayak@ti.com> <1377775391-13103-4-git-send-email-rnayak@ti.com> <871u5c2z3a.fsf@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from devils.ext.ti.com ([198.47.26.153]:43199 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754035Ab3H2RZh (ORCPT ); Thu, 29 Aug 2013 13:25:37 -0400 In-Reply-To: <871u5c2z3a.fsf@linaro.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Rajendra Nayak , tony@atomide.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, bcousson@baylibre.com, nsekhar@ti.com, paul@pwsan.com On Thursday 29 August 2013 01:20 PM, Kevin Hilman wrote: > Rajendra Nayak writes: > >> In order to handle errata I688, a page of sram was reserved by doing a >> static iotable map. Now that we use gen_pool to manage sram, we can >> completely remove all of these static mappings and use gen_pool_alloc() >> to get the one page of sram space needed to implement errata I688. >> >> Suggested-by: Sekhar Nori >> Signed-off-by: Rajendra Nayak > > [...] > >> @@ -71,6 +72,21 @@ void omap_bus_sync(void) >> } >> EXPORT_SYMBOL(omap_bus_sync); >> >> +static int __init omap4_sram_init(void) >> +{ >> + struct device_node *np; >> + struct gen_pool *sram_pool; >> + >> + np = of_find_compatible_node(NULL, NULL, "ti,omap4-mpu"); >> + if (!np) >> + pr_warn("%s:Unable to allocate sram needed to handle errata I688\n", >> + __func__); >> + sram_pool = of_get_named_gen_pool(np, "sram", 0); > > I haven't actually tested this, but if there is no 'sram' property defined... > If the sram property is not defined, the bus_sync will be just a nop. Below check will take care of it. if (dram_sync && sram_sync) Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Thu, 29 Aug 2013 13:25:04 -0400 Subject: [PATCH v2 3/3] ARM: OMAP4+: Remove static iotable mappings for SRAM In-Reply-To: <871u5c2z3a.fsf@linaro.org> References: <1377775391-13103-1-git-send-email-rnayak@ti.com> <1377775391-13103-4-git-send-email-rnayak@ti.com> <871u5c2z3a.fsf@linaro.org> Message-ID: <521F83F0.9080503@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thursday 29 August 2013 01:20 PM, Kevin Hilman wrote: > Rajendra Nayak writes: > >> In order to handle errata I688, a page of sram was reserved by doing a >> static iotable map. Now that we use gen_pool to manage sram, we can >> completely remove all of these static mappings and use gen_pool_alloc() >> to get the one page of sram space needed to implement errata I688. >> >> Suggested-by: Sekhar Nori >> Signed-off-by: Rajendra Nayak > > [...] > >> @@ -71,6 +72,21 @@ void omap_bus_sync(void) >> } >> EXPORT_SYMBOL(omap_bus_sync); >> >> +static int __init omap4_sram_init(void) >> +{ >> + struct device_node *np; >> + struct gen_pool *sram_pool; >> + >> + np = of_find_compatible_node(NULL, NULL, "ti,omap4-mpu"); >> + if (!np) >> + pr_warn("%s:Unable to allocate sram needed to handle errata I688\n", >> + __func__); >> + sram_pool = of_get_named_gen_pool(np, "sram", 0); > > I haven't actually tested this, but if there is no 'sram' property defined... > If the sram property is not defined, the bus_sync will be just a nop. Below check will take care of it. if (dram_sync && sram_sync) Regards, Santosh