From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCH V5] gpio: New driver for LSI ZEVIO SoCs Date: Thu, 29 Aug 2013 14:29:32 -0600 Message-ID: <521FAF2C.5070606@wwwdotorg.org> References: <1377541133-7427-1-git-send-email-fabian@ritter-vogt.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:49169 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751659Ab3H2U3h (ORCPT ); Thu, 29 Aug 2013 16:29:37 -0400 In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Fabian Vogt Cc: Linus Walleij , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , "devicetree@vger.kernel.org" , Grant Likely , Pawel Moll , Rob Herring , Mark Rutland , Ian Campbell On 08/29/2013 02:28 PM, Fabian Vogt wrote: >> On 08/26/2013 12:18 PM, Fabian Vogt wrote: >>> This driver supports the GPIO controller found in LSI ZEVIO SoCs. >>> It has been successfully tested on a TI nspire CX calculator. >>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt >>> b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt >>> +- #gpio-cells = <2> >> This should describe what those cells are. For example perhaps: >> >> #gpio-cells. Must be 2. The first cell is the GPIO number. The second >> cell is used to specify optional parameters: >> - bit 0 specifies polarity (0 for normal, 1 for inverted) > > "Must be 2. The second cell is ... optional"? I'm not sure what your question is, but perhaps this will answer it: The 2nd cell isn't optional, but setting the various flags within the cell is optional.