From: Roland Dreier <roland@topspin.com>
To: tom.l.nguyen@intel.com, linux-kernel@vger.kernel.org
Cc: greg@kroah.com
Subject: [PATCH] Export msi_remove_pci_irq_vectors
Date: Mon, 21 Jun 2004 21:03:22 -0700 [thread overview]
Message-ID: <521xk8qlx1.fsf@topspin.com> (raw)
In-Reply-To: <52lligqqlc.fsf@topspin.com> (Roland Dreier's message of "Mon, 21 Jun 2004 19:22:23 -0700")
As a followup to my previous post about the request_mem_region in
msi.c, I noticed that the region is only released in
msi_remove_pci_irq_vectors(). Based on the fact that this function is
declared in linux/pci.h (and stubbed out if CONFIG_PCI_USE_VECTOR is
not defined), I'm guessing that the intent is for a device driver to
unconditionally call this when exiting.
However, a module can't call msi_remove_pci_irq_vectors unless the
symbol is exported... so if this is the way to do things, please apply
this patch.
On the other hand, MSI-HOWTO.txt seems to imply that the 0th MSI
vector should be cleaned up just by calling free_irq... so should
pci_disable_msi be calling msi_remove_pci_irq_vectors?
- Roland
Index: linux-2.6.7/drivers/pci/msi.c
===================================================================
--- linux-2.6.7.orig/drivers/pci/msi.c 2004-06-15 22:20:03.000000000 -0700
+++ linux-2.6.7/drivers/pci/msi.c 2004-06-21 20:51:33.000000000 -0700
@@ -1011,3 +1011,4 @@
EXPORT_SYMBOL(pci_enable_msi);
EXPORT_SYMBOL(msi_alloc_vectors);
EXPORT_SYMBOL(msi_free_vectors);
+EXPORT_SYMBOL(msi_remove_pci_irq_vectors);
next prev parent reply other threads:[~2004-06-22 4:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-22 2:22 Question on using MSI in PCI driver Roland Dreier
2004-06-22 3:50 ` Jeff Garzik
2004-06-22 3:54 ` Roland Dreier
2004-06-22 4:01 ` Jeff Garzik
2004-06-22 4:04 ` Roland Dreier
2004-06-22 4:03 ` Roland Dreier [this message]
2004-06-22 4:35 ` [PATCH] Fix MSI-X setup Roland Dreier
2004-06-22 23:23 ` Greg KH
2004-06-22 23:57 ` Roland Dreier
2004-06-23 0:04 ` Greg KH
2004-06-22 8:45 ` [PATCH] Export msi_remove_pci_irq_vectors Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2004-06-22 15:47 Nguyen, Tom L
2004-06-22 17:51 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=521xk8qlx1.fsf@topspin.com \
--to=roland@topspin.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.