From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFIMt-0001t2-St for qemu-devel@nongnu.org; Fri, 30 Aug 2013 02:39:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFIMl-0000e8-Fg for qemu-devel@nongnu.org; Fri, 30 Aug 2013 02:39:39 -0400 Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]:54248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFIMl-0000dz-8z for qemu-devel@nongnu.org; Fri, 30 Aug 2013 02:39:31 -0400 Received: by mail-ee0-f42.google.com with SMTP id b45so694270eek.15 for ; Thu, 29 Aug 2013 23:39:30 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <52203E1C.4060208@redhat.com> Date: Fri, 30 Aug 2013 08:39:24 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1377170965-9905-1-git-send-email-aik@ozlabs.ru> <1377170965-9905-4-git-send-email-aik@ozlabs.ru> <1377703099.10408.71.camel@ul30vt.home> <521E9DF5.9080709@ozlabs.ru> <1377740545.10408.145.camel@ul30vt.home> <521EB16F.9010303@ozlabs.ru> <521EEA64.7000708@redhat.com> <521EF0FD.5080906@ozlabs.ru> <521F0B5C.3090102@redhat.com> <52203889.40307@ozlabs.ru> In-Reply-To: <52203889.40307@ozlabs.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/3] vfio: Fix 128 bit handling List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Peter Maydell , Alex Williamson , qemu-devel@nongnu.org Il 30/08/2013 08:15, Alexey Kardashevskiy ha scritto: >> > What if you just merge the two series together? > It will still be a function which can accept sections bigger than 2^64 and > theoretically call int128_get64() and assert. I would think that every time > when anyone calls int128_get64(), the value should be checked for <2^64. It > is like division by zero :) I understood that int128_get64() would be called only for RAM sections, not for IOMMUs (and RAM sections cannot be 2^64-bytes large). Is this wrong? Paolo