Re: [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions

[Wenchao Xia <xiawenc@linux.vnet.ibm.com>]

于 2013-8-30 2:36, Luiz Capitulino 写道:
> On Thu, 29 Aug 2013 11:02:26 -0600
> Eric Blake <eblake@redhat.com> wrote:
>
>> On 08/29/2013 10:33 AM, Luiz Capitulino wrote:
>>
>>>>>
>>>>> Strange, it appears on your pull request... But anyway, your series
>>>>> made it into 1.6.0, so I think we'll need the missing patch in 1.6.1 too?
>>>>
>>>> There's no user in 1.6 (or would we have a build failure) because I
>>>> didn't merge blockdev-add, so I guess it doesn't matter.
>>>
>>> I won't say it's a huge deal, but any downstreamers basing on 1.6 will
>>> have a hard time if they backport blockdev-add or any future command
>>> that my depend on this.
>>
>> Any downstreamers that plans to backport blockdev-add would also
>> backport this as part of their efforts.  I don't see that as any
>> different from any other backport effort that includes requiring
>> multiple non-contiguous pre-req patches.
>
> Backport work can be hard. I'd praise people for making it easier
> for me and would curse people for making it harder for no reason.
>
>> We don't need it on the 1.6
>> stable tree, and downstream is no worse for the wear.
>
> Why is the feature there in the first place then?
>
   Guess it is for a better way to enable Fam Zheng's point in time
block snapshot, which need to create a temporary BDS. This series
provide a more general way to manage the BDS life cycle?
   I just noticed this series, it seems an example as a block layer
interface design, looking forward to V2.

-- 
Best Regards

Wenchao Xia