From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56559) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFJNE-0003eg-RM for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:44:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFJN4-0003Su-8N for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:44:04 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:58763) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFJN4-0003Sm-1i for qemu-devel@nongnu.org; Fri, 30 Aug 2013 03:43:54 -0400 Received: by mail-pa0-f47.google.com with SMTP id kl13so1983675pab.6 for ; Fri, 30 Aug 2013 00:43:53 -0700 (PDT) Message-ID: <52204D28.3010702@ozlabs.ru> Date: Fri, 30 Aug 2013 17:43:36 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1375863692-12207-1-git-send-email-aik@ozlabs.ru> <1375863692-12207-8-git-send-email-aik@ozlabs.ru> <8B8DDF27-87D9-4F0C-917C-85C22D417596@suse.de> In-Reply-To: <8B8DDF27-87D9-4F0C-917C-85C22D417596@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/8] spapr vfio: add spapr-pci-vfio-host-bridge to support vfio List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Anthony Liguori , "Michael S . Tsirkin" , "qemu-devel@nongnu.org qemu-devel" , Alex Williamson , "qemu-ppc@nongnu.org list:PowerPC" , Paolo Bonzini , Paul Mackerras , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , David Gibson On 08/27/2013 09:08 PM, Alexander Graf wrote: >> type_init(register_types); >> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c >> index 869ca43..3f37cac 100644 >> --- a/hw/ppc/spapr_pci.c >> +++ b/hw/ppc/spapr_pci.c > > I think we should move the vfio phb into a separate file and make it be a proper subclass without even the chance to randomly call normal spapr pci functions ;). > > Andreas, could you please check through this and see if you can spot a way to isolate it out? After the lesson you both gave me with xics/xics-kvm, I am (more or less) aware of what I need to change here so wait a bit till I post another version. -- Alexey