From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Matt Wilson <msw@amazon.com>
Cc: xen-devel@lists.xenproject.org, Keir Fraser <keir@xen.org>,
Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH 2/2] x86: remove Pentium Pro check
Date: Fri, 30 Aug 2013 09:52:28 +0100 [thread overview]
Message-ID: <52205D4C.4030407@citrix.com> (raw)
In-Reply-To: <1377828849-18059-2-git-send-email-msw@amazon.com>
On 30/08/13 03:14, Matt Wilson wrote:
> ... as it's not a supported processor
>
> Signed-off-by: Matt Wilson <msw@amazon.com>
> Cc: Keir Fraser <keir@xen.org>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
> xen/arch/x86/cpu/intel.c | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/xen/arch/x86/cpu/intel.c b/xen/arch/x86/cpu/intel.c
> index 072ecbc..31b69c9 100644
> --- a/xen/arch/x86/cpu/intel.c
> +++ b/xen/arch/x86/cpu/intel.c
> @@ -198,10 +198,6 @@ static void __devinit init_intel(struct cpuinfo_x86 *c)
> set_bit(X86_FEATURE_ARCH_PERFMON, c->x86_capability);
> }
>
> - /* SEP CPUID bug: Pentium Pro reports SEP but doesn't have it until model 3 mask 3 */
> - if ((c->x86<<8 | c->x86_model<<4 | c->x86_mask) < 0x633)
> - clear_bit(X86_FEATURE_SEP, c->x86_capability);
> -
> if ( !cpu_has(c, X86_FEATURE_XTOPOLOGY) )
> {
> c->x86_max_cores = num_cpu_cores(c);
next prev parent reply other threads:[~2013-08-30 8:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 2:14 [PATCH 1/2] x86: remove X86_INTEL_USERCOPY code Matt Wilson
2013-08-30 2:14 ` [PATCH 2/2] x86: remove Pentium Pro check Matt Wilson
2013-08-30 5:24 ` Keir Fraser
2013-08-30 8:52 ` Andrew Cooper [this message]
2013-08-30 8:46 ` [PATCH 1/2] x86: remove X86_INTEL_USERCOPY code Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52205D4C.4030407@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=msw@amazon.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.