From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] drivers: video: i740fb: add 'default' processing contents for 'switch'.
Date: Fri, 30 Aug 2013 10:52:03 +0000 [thread overview]
Message-ID: <52207953.309@ti.com> (raw)
In-Reply-To: <51ECF12D.8060903@asianux.com>
[-- Attachment #1: Type: text/plain, Size: 956 bytes --]
On 30/08/13 13:41, Chen Gang wrote:
> On 08/30/2013 06:19 PM, Tomi Valkeinen wrote:
>> Here's some old discussion about BUG:
>>
>> http://yarchive.net/comp/linux/BUG.html
>>
>
> Yeah, if it is not a real bug (can handle it), we should not use BUG(),
> but when we are sure it is a kernel bug, and the kernel will continue
> blindly, we need use BUG() to stop it.
>
> Just like the Linus Torvalds said in the link which you provide:
>
> "Rule of thumb: BUG() is only good for something that never happens and
> that we really have no other option for (ie state is so corrupt that
> continuing is deadly)".
I guess this is where we disagree. I don't see having a corrupt bpp
value in a fb driver's internal function as "so corrupt that continuing
is deadly".
Anyway, if you insist on the BUG(), I'll leave this patch to
Jean-Christophe. I'm only taking small-ish patches that have no open
issues or disagreements.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 901 bytes --]
next prev parent reply other threads:[~2013-08-30 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 8:45 [PATCH] drivers: video: i740fb: add 'default' processing contents for 'switch' Chen Gang
2013-08-30 7:21 ` Tomi Valkeinen
2013-08-30 8:17 ` Chen Gang
2013-08-30 8:36 ` Tomi Valkeinen
2013-08-30 8:44 ` Chen Gang
2013-08-30 9:16 ` Tomi Valkeinen
2013-08-30 9:45 ` Chen Gang
2013-08-30 10:19 ` Tomi Valkeinen
2013-08-30 10:41 ` Chen Gang
2013-08-30 10:52 ` Tomi Valkeinen [this message]
2013-09-02 1:41 ` Chen Gang
2013-09-02 6:45 ` Tomi Valkeinen
2013-09-02 6:45 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52207953.309@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.