[U-Boot] [PATCH 00/12] tegra: nyan-big: Support chainloading and add documentation

[Tom Warren <TWarren@nvidia.com>]

Simon,

> -----Original Message-----
> From: sjg at google.com [mailto:sjg at google.com] On Behalf Of Simon Glass
> Sent: Wednesday, June 07, 2017 4:59 AM
> To: Matthew Gorski <matt.gorski@gmail.com>
> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Sjoerd Simons
> <sjoerd.simons@collabora.co.uk>; Tomeu Vizoso
> <tomeu.vizoso@collabora.com>; Riley Baird <riley@openmailbox.org>; Heiko
> Schocher <hs@denx.de>; Patrick Delaunay <patrick.delaunay@st.com>;
> Masahiro Yamada <yamada.masahiro@socionext.com>; Tom Warren
> <TWarren@nvidia.com>; Anatolij Gustschin <agust@denx.de>; Jagannadha
> Sutradharudu Teki <jagannadh.teki@gmail.com>; Keerthy <j-keerthy@ti.com>;
> Stephen Warren <swarren@wwwdotorg.org>; Jagan Teki
> <jagan@openedev.com>; Marek Vasut <marex@denx.de>; Albert Aribaud
> <albert.u.boot@aribaud.net>; Stefan Agner <stefan.agner@toradex.com>;
> Allen Martin <AMartin@nvidia.com>; Alexander Graf <agraf@suse.de>;
> Jaehoon Chung <jh80.chung@samsung.com>; Stephen Warren
> <swarren@nvidia.com>
> Subject: Re: [PATCH 00/12] tegra: nyan-big: Support chainloading and add
> documentation
> 
> Hi,
> 
> On 1 June 2017 at 07:52, Matthew Gorski <matt.gorski@gmail.com> wrote:
> >
> > On Wed, May 31, 2017 at 2:28 PM, Matthew Gorski
> > <matt.gorski@gmail.com>
> > wrote:
> >>
> >>
> >>
> >> On Mon, May 22, 2017 at 7:17 AM, Simon Glass <sjg@chromium.org>
> wrote:
> >>>
> >>> Every now and then someone wants to chain-load U-Boot on a
> Chromebook.
> >>> The procedure is not very complicated but there are some oddities.
> >>>
> >>> This series updates a few things with allow U-Boot to start on
> >>> nyan-big in this way and adds documentation on how to do it. This
> >>> provides a central place where the procedure on different devices can be
> documented.
> >>>
> >>>
> >>> Simon Glass (12):
> >>>   arm: arm720t: Support CONFIG_SKIP_LOWLEVEL_INIT_ONLY
> >>>   tegra: Init clocks even when SPL did not run
> >>>   tegra: dts: Add cros-ec SPI settings
> >>>   arm: Rename HCTR to HTCR
> >>>   arm: Don't try to support CONFIG_ARMV7_LPAE on ARMv4T
> >>>   arm: Disable LPAE if not enabled
> >>>   tegra: spi: Wait a little after setting the clocks
> >>>   tegra: nyan-big: Enable the dhrystone benchmark
> >>>   tegra: video: Don't power up the SOR twice
> >>>   tegra: Enable CP15 init
> >>>   tegra: clock: Avoid a divide-by-zero error
> >>>   README: Add instructions for chain-loading U-Boot
> >>>
> >>>  arch/arm/cpu/arm720t/start.S                 |   6 +-
> >>>  arch/arm/dts/tegra124-nyan-big-u-boot.dtsi   |   9 ++
> >>>  arch/arm/include/asm/arch-tegra/clock.h      |   3 +
> >>>  arch/arm/lib/cache-cp15.c                    |  13 +-
> >>>  arch/arm/mach-tegra/board2.c                 |   3 +
> >>>  arch/arm/mach-tegra/clock.c                  |  10 +-
> >>>  arch/arm/mach-tegra/tegra124/clock.c         |  18 +++
> >>>  configs/nyan-big_defconfig                   |   2 +
> >>>  doc/README.chromium                          | 222
> >>> +++++++++++++++++++++++++++
> >>>  doc/chromium/devkeys/kernel.keyblock         | Bin 0 -> 1208 bytes
> >>>  doc/chromium/devkeys/kernel_data_key.vbprivk | Bin 0 -> 1199 bytes
> >>>  drivers/spi/tegra114_spi.c                   |   1 +
> >>>  drivers/video/tegra124/sor.c                 |   9 ++
> >>>  include/configs/tegra-common-post.h          |   2 +-
> >>>  14 files changed, 292 insertions(+), 6 deletions(-)  create mode
> >>> 100644 doc/README.chromium  create mode 100644
> >>> doc/chromium/devkeys/kernel.keyblock
> >>>  create mode 100644 doc/chromium/devkeys/kernel_data_key.vbprivk
> >>>
> >> Thank You for this Simon!  Very much appreciated!  I am going to give
> >> this a try later tonight and report back my personal results...
> >>>
> >>> --
> >>> 2.13.0.303.g4ebf302169-goog
> >>>
> >>
> > Confirmed! Chain-loading working on my nyan_big.  I appreciate this
> > very much Simon and all who contributed.
> 
> I'd like to pull in this series. Are there any comments / reviews? If affects both
> tegra and rockchip.
I'm fine with it - I assume you'll pull it in to one of your repos and post a PR to get it into mainstream U-Boot?
I don't have the HW to test on (my nyan-big has been shelved), but trust in Matthew's testing, and that Stephen's U-Boot test scripts will catch any problems, so LGTM.

Tom
> 
> Regards,
> Simon
--
nvpublic