From: Hannes Reinecke <hare@suse.de>
To: Christoph Hellwig <hch@infradead.org>
Cc: James Bottomley <jbottomley@parallels.com>,
linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
Ren Mingxin <renmx@cn.fujitsu.com>, Joern Engel <joern@logfs.org>,
James Smart <james.smart@emulex.com>,
Bart Van Assche <bvanassche@acm.org>,
Roland Dreier <roland@purestorage.com>
Subject: Re: [PATCH 4/9] virtio_scsi: Enable new EH timeout handler
Date: Fri, 30 Aug 2013 14:47:43 +0200 [thread overview]
Message-ID: <5220946F.2050001@suse.de> (raw)
In-Reply-To: <20130830124541.GA4107@infradead.org>
On 08/30/2013 02:45 PM, Christoph Hellwig wrote:
>>
>> +static enum blk_eh_timer_return virtscsi_timedout(struct scsi_cmnd *scmd)
>> +{
>> + scsi_abort_command(scmd);
>> + return BLK_EH_SCHEDULED;
>> +}
>
> just set the method vector to scsi_abort_command here and in all the
> other trivial conversions instead of having all those pointless
> wrappers.
>
Ok.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-08-30 12:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-29 13:32 [PATCHv4 0/9] New EH command timeout handler Hannes Reinecke
2013-08-29 13:32 ` [PATCH 1/9] scsi: Fix erratic device offline during EH Hannes Reinecke
2013-08-29 13:32 ` [PATCH 2/9] blk-timeout: add BLK_EH_SCHEDULED return code Hannes Reinecke
2013-08-29 13:32 ` [PATCH 3/9] scsi: improved eh timeout handler Hannes Reinecke
2013-08-29 13:32 ` [PATCH 4/9] virtio_scsi: Enable new EH " Hannes Reinecke
2013-08-30 12:45 ` Christoph Hellwig
2013-08-30 12:47 ` Hannes Reinecke [this message]
2013-08-29 13:32 ` [PATCH 5/9] libsas: " Hannes Reinecke
2013-08-29 13:32 ` [PATCH 6/9] mptsas: " Hannes Reinecke
2013-08-29 13:32 ` [PATCH 7/9] mpt2sas: " Hannes Reinecke
2013-08-29 13:32 ` [PATCH 8/9] mpt3sas: " Hannes Reinecke
2013-08-29 13:32 ` [PATCH 9/9] scsi_transport_fc: " Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2013-09-02 7:12 [PATCHv5 0/9] New EH command " Hannes Reinecke
2013-09-02 7:13 ` [PATCH 4/9] virtio_scsi: Enable new EH " Hannes Reinecke
2013-07-01 14:24 [PATCHv3 0/9] New EH command " Hannes Reinecke
2013-07-01 14:24 ` [PATCH 4/9] virtio_scsi: Enable new EH " Hannes Reinecke
2013-06-10 7:40 [PATCHv2 0/9] New SCSI command " Hannes Reinecke
2013-06-10 7:40 ` [PATCH 4/9] virtio_scsi: Enable new EH " Hannes Reinecke
2013-06-12 14:54 ` Paolo Bonzini
2013-06-13 1:58 ` Asias He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5220946F.2050001@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=emilne@redhat.com \
--cc=hch@infradead.org \
--cc=james.smart@emulex.com \
--cc=jbottomley@parallels.com \
--cc=joern@logfs.org \
--cc=linux-scsi@vger.kernel.org \
--cc=renmx@cn.fujitsu.com \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.