All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
	Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/2] qemu-iotests: Snapshotting zero clusters
Date: Fri, 30 Aug 2013 07:12:36 -0600	[thread overview]
Message-ID: <52209A44.2010804@redhat.com> (raw)
In-Reply-To: <52209958.90102@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 953 bytes --]

On 08/30/2013 07:08 AM, Eric Blake wrote:
> On 08/30/2013 07:07 AM, Eric Blake wrote:
>> On 08/30/2013 02:36 AM, Max Reitz wrote:
>>> This test creates an image with unallocated zero clusters, then creates
>>> a snapshot. Afterwards, there should be neither any errors nor leaks.
>>>
>>> Signed-off-by: Max Reitz <mreitz@redhat.com>
>>> ---
>>>  tests/qemu-iotests/062   | 64 ++++++++++++++++++++++++++++++++++++++++++++++++
>>>  tests/qemu-iotests/group |  1 +
>>>  2 files changed, 65 insertions(+)
>>>  create mode 100755 tests/qemu-iotests/062
>>
>> ACK.
> 
> Sorry, I'm mixing list conventions.  That should be:
> 
> Reviewed-by: Eric Blake <eblake@redhat.com>

and just now, I notice the v3 patch that provides the expected output.
Serves me right for trying to review first thing in the morning before
breakfast.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]

      reply	other threads:[~2013-08-30 13:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  8:36 [Qemu-devel] [PATCH v2 0/2] qcow2: Snapshot update for zero clusters Max Reitz
2013-08-30  8:36 ` [Qemu-devel] [PATCH v2 1/2] qcow2-refcount: " Max Reitz
2013-08-30 13:02   ` Eric Blake
2013-08-30  8:36 ` [Qemu-devel] [PATCH v2 2/2] qemu-iotests: Snapshotting " Max Reitz
2013-08-30 13:07   ` Eric Blake
2013-08-30 13:08     ` Eric Blake
2013-08-30 13:12       ` Eric Blake [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52209A44.2010804@redhat.com \
    --to=eblake@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.