All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Tinguely <tinguely@sgi.com>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_put_ino
Date: Fri, 30 Aug 2013 08:56:38 -0500	[thread overview]
Message-ID: <5220A496.9040409@sgi.com> (raw)
In-Reply-To: <1377843681-31878-2-git-send-email-david@fromorbit.com>

On 08/30/13 01:21, Dave Chinner wrote:
> From: Dave Chinner<dchinner@redhat.com>
>
> So fix up the export in xfs_dir2.h that is needed by userspace.
>
> Signed-off-by: Dave Chinner<dchinner@redhat.com>
> ---
>   fs/xfs/xfs_dir2.h | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_dir2.h b/fs/xfs/xfs_dir2.h
> index 768ddad..9910401 100644
> --- a/fs/xfs/xfs_dir2.h
> +++ b/fs/xfs/xfs_dir2.h
> @@ -70,8 +70,9 @@ extern void xfs_dir2_sf_put_parent_ino(struct xfs_dir2_sf_hdr *sfp,
>   		xfs_ino_t ino);
>   extern xfs_ino_t xfs_dir3_sfe_get_ino(struct xfs_mount *mp,
>   		struct xfs_dir2_sf_hdr *sfp, struct xfs_dir2_sf_entry *sfep);
> -extern void xfs_dir2_sfe_put_ino( struct xfs_dir2_sf_hdr *,
> -		struct xfs_dir2_sf_entry *sfep, xfs_ino_t ino);
> +extern void xfs_dir3_sfe_put_ino(struct xfs_mount *mp,
> +		struct xfs_dir2_sf_hdr *hdr, struct xfs_dir2_sf_entry *sfep,
> +		xfs_ino_t ino);
>
>   extern int xfs_dir2_isblock(struct xfs_trans *tp, struct xfs_inode *dp, int *r);
>   extern int xfs_dir2_isleaf(struct xfs_trans *tp, struct xfs_inode *dp, int *r);

Okay xfs_dir2_sfe_put_ino() does not exist. xfs_dir3_sfe_put_ino() is 
remotely used in xfs_repair but not in kernel.

Reviewed-by: Mark Tinguely <tinguely@sgi.com>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2013-08-30 13:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  6:21 [PATCH 0/2] xfs: minor cleanups for userspace sanity Dave Chinner
2013-08-30  6:21 ` [PATCH 1/2] xfs: dtype changed xfs_dir2_sfe_put_ino to xfs_dir3_sfe_put_ino Dave Chinner
2013-08-30 13:56   ` Mark Tinguely [this message]
2013-09-02  2:15   ` [PATCH V2] " Dave Chinner
2013-09-03 19:35     ` Ben Myers
2013-08-30  6:21 ` [PATCH 2/2] xfs: XFS_MOUNT_QUOTA_ALL needed by userspace Dave Chinner
2013-08-30 13:58   ` Mark Tinguely
2013-09-03 22:21 ` [PATCH 0/2] xfs: minor cleanups for userspace sanity Ben Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5220A496.9040409@sgi.com \
    --to=tinguely@sgi.com \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.