Re: [RFC 06/10] ARM: shmobile: r8a7790: add I2C clock

[Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>]

Hello.

On 08/30/2013 04:37 PM, Ulrich Hecht wrote:

> From: Nguyen Viet Dung <nv-dung@jinso.co.jp>

> This patch add clock for I2C bus.

> Signed-off-by: Nguyen Viet Dung <nv-dung@jinso.co.jp>
> ---
>   arch/arm/mach-shmobile/clock-r8a7790.c | 11 +++++++++++
>   1 file changed, 11 insertions(+)

> diff --git a/arch/arm/mach-shmobile/clock-r8a7790.c b/arch/arm/mach-shmobile/clock-r8a7790.c
> index d99b87b..05cd34b 100644
> --- a/arch/arm/mach-shmobile/clock-r8a7790.c
> +++ b/arch/arm/mach-shmobile/clock-r8a7790.c
[...]
> @@ -181,6 +182,7 @@ static struct clk div6_clks[DIV6_NR] = {
>
>   /* MSTP */
>   enum {
> +	MSTP931, MSTP930, MSTP929, MSTP928,

    Please break the line after "MSTP930,".

[...]
> @@ -286,6 +293,10 @@ static struct clk_lookup lookups[] = {
>   	CLKDEV_DEV_ID("ee220000.mmcif", &mstp_clks[MSTP305]),
>   	CLKDEV_DEV_ID("sh_mmcif.1", &mstp_clks[MSTP305]),
>   	CLKDEV_DEV_ID("sh_cmt.0", &mstp_clks[MSTP124]),
> +	CLKDEV_DEV_ID("i2c-rcar.0", &mstp_clks[MSTP931]),
> +	CLKDEV_DEV_ID("i2c-rcar.1", &mstp_clks[MSTP930]),
> +	CLKDEV_DEV_ID("i2c-rcar.2", &mstp_clks[MSTP929]),
> +	CLKDEV_DEV_ID("i2c-rcar.3", &mstp_clks[MSTP928]),

    These should be sorted downwards by MSTPxxx index, no?

WBR, Sergei