From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53723) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFTrB-0003Jv-5m for qemu-devel@nongnu.org; Fri, 30 Aug 2013 14:55:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VFTr6-0005VG-FW for qemu-devel@nongnu.org; Fri, 30 Aug 2013 14:55:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VFTr6-0005V6-6i for qemu-devel@nongnu.org; Fri, 30 Aug 2013 14:55:36 -0400 Message-ID: <5220EAA1.8010301@redhat.com> Date: Fri, 30 Aug 2013 12:55:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1377508321-16507-1-git-send-email-alex@alex.org.uk> <1377508321-16507-2-git-send-email-alex@alex.org.uk> <5220D708.7050802@redhat.com> <2912C057-823A-4935-B8CE-76E47B8CD8B3@alex.org.uk> In-Reply-To: <2912C057-823A-4935-B8CE-76E47B8CD8B3@alex.org.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1Q1JXBoSjdXUPTJI21GdO3pDp2m7rjjkl" Subject: Re: [Qemu-devel] [PATCHv5] add qemu-img convert -n option (skip target volume creation) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alex Bligh Cc: Kevin Wolf , Anthony Liguori , Fam Zheng , qemu-devel@nongnu.org, Alexandre Derumier , Stefan Hajnoczi , Paolo Bonzini This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1Q1JXBoSjdXUPTJI21GdO3pDp2m7rjjkl Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 08/30/2013 12:13 PM, Alex Bligh wrote: >>> +# test of qemu-img convert -n - convert without creation >>> +# >>> +# Copyright (C) 2009 Red Hat, Inc. >=20 >> Where have you been the last 4 years? I could understand a range of >> years, if this test borrows significantly from another file that old, >> but I suspect that just 2013 is probably more accurate. >=20 > I've been not at Redhat for any of it! >=20 > I wasn't too sure what to do with the copyright string. The body of > the code was copied from another test (058 if I remember rightly) > which had the above copyright string which is presumably that old. If so, and if I reviewed that patch, shame on me for not noticing the stale year on that test :) > Redhat don't have any copyright in the stuff I added so there is > no (c) Redhat newer than (presumably) 2009 (I'm presuming qemu > doesn't require contributor assignment). My copyright would be 2013. Your own work is non-trivial - by virtue of the fact that you list: +owner=3Dalex@alex.org.uk you are stating that there is enough new content comprising this test that you feel comfortable being listed as the point of contact for the fi= le. > But removing Redhat's (c) or altering it did not seem right. Indeed, since you are copying a substantial amount of template from Red Hat's copyright. >=20 > I'm really not bothered about having my own string in there > particularly for such a meagre bit of code, but I suppose most > accurate would be: >=20 > (c) 2009 Red Hat, Inc. > (c) 2013 Alex Bligh Yes, that looks like the best approach. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1Q1JXBoSjdXUPTJI21GdO3pDp2m7rjjkl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSIOqhAAoJEKeha0olJ0Nq3zAH/A7aqo1ntemPoccnZjOdwTUL uvqeXeIZU0QAgji3GLr53HWHLT5Axn8agQqZkDry8LO2bygiaGLXVn84nexZ5GYA xHnGWhBnaxqTEVoqZmAKZHqLub/nLQwEKpe4Fw7eT+WWtowIRZDhU+LFwF54NBzi MXrOXSjuloMt6qdmwBFIVsZU9iSjNHHFIOHpp4rDI1mPdovFbBWEruH8/x/X3ckR L6YytXC9xrwRiVmPkCNgMFBPRIDgm0JUkPN5rz9N/LcfiB8gB6sDSkxDG747PAMS Q4k+tIOuuwpnLhR1u9CLYm8d8bZdeF64qoZ5B8doVVBCVuiPpZ9Uw7Bah4tLtJ4= =58SB -----END PGP SIGNATURE----- --1Q1JXBoSjdXUPTJI21GdO3pDp2m7rjjkl--